Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.8.2
-
Fix Version/s: 3.0
-
Component/s: ICE-Components
-
Labels:None
-
Environment:ICEfaces 3, ice:gmap component
-
Assignee Priority:P1
-
Affects:Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration
Description
However, this preloading is not efficient as it causes the gmap JavaScript to be loaded and evaluated each time a page is loaded, even if the component is not being used on that page. This JIRA is to add a mechanism (config. param?) that would allow the application to opt. out of the gmap Javascript preload if that component is not being used.
A similar issue was recently resolved for ice:inputRichText via
Issue Links
- blocks
-
ICE-8166
ICEfaces Showcase sample app. - Remove legacy use of NavigationController.refreshPage()
-
- Closed
-
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
Changed strategy used to insert Google Maps script code into the 'head'. Created dummy/empty gmap.js resource and referenced by GMap component. Introduced GMapResourceHandler which replaces dynamically gmap.js' request URL with the URL pointing to Google code.
After testing this change, it is clear that we will still want the old behaviour of being able to "Switch-off" the loading of gmap JS if there is no gmap key present in the web.xml file. The reason for this is that if you have an application where mandatoryResource="all", and you are not using the gmap component, it will still attempt to load it and you will see a nasty popup alert from Google complaining about the gmap key.
So basically, the mandatory resource impl. for ice:gmap should internally check for the gmap key in the web.xml, and bail on loading if it isn't present.
Changed GMapResourceHandler to disable Google Maps code loading when key is not provided.
Annotated GMapRenderer as mandatory resource. Moved ExternalScript annotation to the component and changed its processing to be executed with the rest of mandatory resource dependencies. Renamed ExternalScript to ExternalResourceDependency. Updated component-showcase web.xml to include GMap component in the list of mandatoryResourceConfiguration parameter.