ICEfaces
  1. ICEfaces
  2. ICE-7615

ace:pushButton - style or styleClass only applied to the html button element

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 3.0.RC1, 3.0.RC2
          • Fix Version/s: 3.0
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            ICEfaces 3.0
          • Assignee Priority:
            P1
          • Affects:
            Compatibility/Configuration

            Description

            When setting a style or styleClass on the ace:pushButton the CSS is applied to the html button tag and not the surrounding html elements that are rendered for the pushButton component.

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Arran Mccullough added a comment -

              Attached test case showing issue

              Show
              Arran Mccullough added a comment - Attached test case showing issue
              Hide
              Permalink
              yip.ng added a comment - - edited

              This I think was done on purpose. I remember we had some discussion on this long time ago in a meeting.

              Show
              yip.ng added a comment - - edited This I think was done on purpose. I remember we had some discussion on this long time ago in a meeting.
              Hide
              Permalink
              yip.ng added a comment -

              Style and style class added to root div.

              Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\pushbutton\PushButtonRenderer.java
              Completed: At revision: 27091

              Show
              yip.ng added a comment - Style and style class added to root div. Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\pushbutton\PushButtonRenderer.java Completed: At revision: 27091
              Hide
              Permalink
              Ken Fyten added a comment -

              In order to be consistent with the other ACE components, we should change this so that the style and styleClass attributes are always only rendered to the outside containing DIV (or SPAN) and not the internal component.

              This issue may also exist with the other buttons so those should be reviewed and changed as needed.

              Show
              Ken Fyten added a comment - In order to be consistent with the other ACE components, we should change this so that the style and styleClass attributes are always only rendered to the outside containing DIV (or SPAN) and not the internal component. This issue may also exist with the other buttons so those should be reviewed and changed as needed.
              Hide
              Permalink
              yip.ng added a comment - - edited

              Done. See screenshot-2.png. NB: This may break the styling in existing apps, depending on how the existing CSS rules are formulated.

              Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\checkboxbutton\CheckboxButtonRenderer.java
              Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\linkbutton\LinkButtonRenderer.java
              Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\pushbutton\PushButtonRenderer.java
              Completed: At revision: 27107

              Show
              yip.ng added a comment - - edited Done. See screenshot-2.png. NB: This may break the styling in existing apps, depending on how the existing CSS rules are formulated. Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\checkboxbutton\CheckboxButtonRenderer.java Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\linkbutton\LinkButtonRenderer.java Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\pushbutton\PushButtonRenderer.java Completed: At revision: 27107
              Hide
              Permalink
              Carmen Cristurean added a comment - - edited

              Tested fix for PushButton & LinkButton with code revision 27142, in FF3.6, Chrome15 and IE8.

              Show
              Carmen Cristurean added a comment - - edited Tested fix for PushButton & LinkButton with code revision 27142, in FF3.6, Chrome15 and IE8.

                People

                • Assignee:
                  yip.ng
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: