ICEfaces
  1. ICEfaces
  2. ICE-7517

Refactor dialog comps to avoid client-side dom movement/repositioning of server-rendered markup.

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 3.0.RC1
          • Fix Version/s: 3.0.RC2, 3.0
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            *
          • Assignee Priority:
            P1
          • Affects:
            Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration

            Description

            Client-side movement/repositioning of DOM fragments don't work well with our DOM diff. and update framework. Need to change dialog components to avoid doing this.

              Issue Links

              blocks

              Bug - A problem which impairs or prevents the functions of the product. ICE-7503 ace:confirmationDialog: Changing the Header or Message values results in double buttons being rendered until next edit.

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                yip.ng created issue -
                yip.ng made changes -
                Field Original Value New Value
                Salesforce Case []
                Fix Version/s 3.0.1 [ 10282 ]
                yip.ng made changes -
                Link This issue blocks ICE-7503 [ ICE-7503 ]
                Ken Fyten made changes -
                Salesforce Case []
                Fix Version/s 3.0 [ 10241 ]
                Fix Version/s 3.0.1 [ 10282 ]
                Affects [Documentation (User Guide, Ref. Guide, etc.)]
                Hide
                Permalink
                Ken Fyten added a comment -

                This affects ace:dialog, ace:confirmationDialog, and ace:notificationPanel. Also verify that ace:tooltip is not affected.

                Show
                Ken Fyten added a comment - This affects ace:dialog, ace:confirmationDialog, and ace:notificationPanel. Also verify that ace:tooltip is not affected.
                Ken Fyten made changes -
                Salesforce Case []
                Assignee Priority P1
                Assignee yip.ng [ yip.ng ]
                Ken Fyten made changes -
                Link This issue blocks ICE-7491 [ ICE-7491 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #26812 Fri Dec 09 14:37:50 MST 2011 yip.ng ICE-7517: Refactor dialog comps to avoid client-side dom movement/repositioning of server-rendered markup.
                Files Changed
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dialog/DialogMeta.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dialog/DialogRenderer.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/dialog/dialog.js
                Hide
                Permalink
                yip.ng added a comment -

                notificationPanel done in ICE-7506.

                Show
                yip.ng added a comment - notificationPanel done in ICE-7506 .
                Hide
                Permalink
                yip.ng added a comment -

                No DOM node movement in tooltip.

                Show
                yip.ng added a comment - No DOM node movement in tooltip.
                yip.ng made changes -
                Attachment screenshot-1.png [ 13867 ]
                Hide
                Permalink
                yip.ng added a comment - - edited

                Dialog layout messed up after svn update. See screenshot-1.png.
                (From Art: clear cache.)

                Show
                yip.ng added a comment - - edited Dialog layout messed up after svn update. See screenshot-1.png. (From Art: clear cache.)
                Hide
                Permalink
                yip.ng added a comment -

                appendToBody attribute removed from dialog.

                Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\dialog\dialog.js
                Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\dialog\DialogMeta.java
                Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\dialog\DialogRenderer.java
                Completed: At revision: 26812

                Show
                yip.ng added a comment - appendToBody attribute removed from dialog. Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\dialog\dialog.js Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\dialog\DialogMeta.java Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\dialog\DialogRenderer.java Completed: At revision: 26812
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #26816 Sun Dec 11 10:48:59 MST 2011 yip.ng ICE-7517: Refactor dialog comps to avoid client-side dom movement/repositioning of server-rendered markup.
                Files Changed
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/confirmationdialog/confirmationdialog.js
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/confirmationdialog/ConfirmationDialogMeta.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/confirmationdialog/ConfirmationDialogRenderer.java
                Hide
                Permalink
                yip.ng added a comment -

                Confirmation dialog:

                • removed appendToBody attribute
                • removed buttons panel node movement

                Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\confirmationdialog\confirmationdialog.js
                Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\confirmationdialog\ConfirmationDialogMeta.java
                Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\confirmationdialog\ConfirmationDialogRenderer.java
                Completed: At revision: 26816

                Show
                yip.ng added a comment - Confirmation dialog: removed appendToBody attribute removed buttons panel node movement Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\confirmationdialog\confirmationdialog.js Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\confirmationdialog\ConfirmationDialogMeta.java Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\confirmationdialog\ConfirmationDialogRenderer.java Completed: At revision: 26816
                yip.ng made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Ken Fyten made changes -
                Salesforce Case []
                Affects [Documentation (User Guide, Ref. Guide, etc.)] [Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration]
                Ken Fyten made changes -
                Fix Version/s 3.0.RC2 [ 10313 ]
                Hide
                Permalink
                yip.ng added a comment -

                ICE-7471.

                Show
                yip.ng added a comment - ICE-7471 .
                Hide
                Permalink
                Carmen Cristurean added a comment -

                Verified fix with revision 27126 in IE8, FF3.6, and Chrome15.

                Show
                Carmen Cristurean added a comment - Verified fix with revision 27126 in IE8, FF3.6, and Chrome15.
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]

                  People

                  • Assignee:
                    yip.ng
                    Reporter:
                    yip.ng
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: