ICEfaces
  1. ICEfaces
  2. ICE-7517

Refactor dialog comps to avoid client-side dom movement/repositioning of server-rendered markup.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.RC1
    • Fix Version/s: 3.0.RC2, 3.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      *
    • Assignee Priority:
      P1
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration

      Description

      Client-side movement/repositioning of DOM fragments don't work well with our DOM diff. and update framework. Need to change dialog components to avoid doing this.

        Issue Links

          Activity

          Hide
          Ken Fyten added a comment -

          This affects ace:dialog, ace:confirmationDialog, and ace:notificationPanel. Also verify that ace:tooltip is not affected.

          Show
          Ken Fyten added a comment - This affects ace:dialog, ace:confirmationDialog, and ace:notificationPanel. Also verify that ace:tooltip is not affected.
          Hide
          yip.ng added a comment -

          notificationPanel done in ICE-7506.

          Show
          yip.ng added a comment - notificationPanel done in ICE-7506 .
          Hide
          yip.ng added a comment -

          No DOM node movement in tooltip.

          Show
          yip.ng added a comment - No DOM node movement in tooltip.
          Hide
          yip.ng added a comment - - edited

          Dialog layout messed up after svn update. See screenshot-1.png.
          (From Art: clear cache.)

          Show
          yip.ng added a comment - - edited Dialog layout messed up after svn update. See screenshot-1.png. (From Art: clear cache.)
          Hide
          yip.ng added a comment -

          appendToBody attribute removed from dialog.

          Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\dialog\dialog.js
          Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\dialog\DialogMeta.java
          Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\dialog\DialogRenderer.java
          Completed: At revision: 26812

          Show
          yip.ng added a comment - appendToBody attribute removed from dialog. Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\dialog\dialog.js Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\dialog\DialogMeta.java Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\dialog\DialogRenderer.java Completed: At revision: 26812
          Hide
          yip.ng added a comment -

          Confirmation dialog:

          • removed appendToBody attribute
          • removed buttons panel node movement

          Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\confirmationdialog\confirmationdialog.js
          Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\confirmationdialog\ConfirmationDialogMeta.java
          Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\confirmationdialog\ConfirmationDialogRenderer.java
          Completed: At revision: 26816

          Show
          yip.ng added a comment - Confirmation dialog: removed appendToBody attribute removed buttons panel node movement Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\confirmationdialog\confirmationdialog.js Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\confirmationdialog\ConfirmationDialogMeta.java Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\confirmationdialog\ConfirmationDialogRenderer.java Completed: At revision: 26816
          Hide
          yip.ng added a comment -
          Show
          yip.ng added a comment - ICE-7471 .
          Hide
          Carmen Cristurean added a comment -

          Verified fix with revision 27126 in IE8, FF3.6, and Chrome15.

          Show
          Carmen Cristurean added a comment - Verified fix with revision 27126 in IE8, FF3.6, and Chrome15.

            People

            • Assignee:
              yip.ng
              Reporter:
              yip.ng
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: