ICEfaces
  1. ICEfaces
  2. ICE-7345

ace:expansionToggler - add onExpansion events

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1-Beta
    • Fix Version/s: 3.0.RC1, 3.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ICEfaces 2.1 Beta
    • Assignee Priority:
      P2
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial

      Description

      Add support for ClientBehavior events for onExpansion, afterExpansion type events.

      Also add support for a new expansionListener server event.

        Activity

        Hide
        Nils Lundquist added a comment -

        Revision #26286 Committed by nils.lundquist Today 3:54 PM

        ICE-7345 - Added ExpansionChangeEvent object and ChangeListener attribute to ExpansionToggler. ExpansionToggler now responsible for decode of expansion row state. Revealed a regression in the processing of row level components. Required local implementation of iterate(), where previously a local implementation of visitTree() was being used in processing. Iterate, being a private method of the superclass could not be overriden, and so its usages in processDecodes/Validators/Updates had to be overriden. These overridden methods are skipping the private preDecode, preValidate and preUpdate calls from the superclass. The effects of this still requires analysis. The operations within these methods require private access to the supeclass and thus couldn't be implemented for the local implementations of the processing calls. Also removes the last usage (besides live scrolling) of custom update in the DataTable.

        Show
        Nils Lundquist added a comment - Revision #26286 Committed by nils.lundquist Today 3:54 PM ICE-7345 - Added ExpansionChangeEvent object and ChangeListener attribute to ExpansionToggler. ExpansionToggler now responsible for decode of expansion row state. Revealed a regression in the processing of row level components. Required local implementation of iterate(), where previously a local implementation of visitTree() was being used in processing. Iterate, being a private method of the superclass could not be overriden, and so its usages in processDecodes/Validators/Updates had to be overriden. These overridden methods are skipping the private preDecode, preValidate and preUpdate calls from the superclass. The effects of this still requires analysis. The operations within these methods require private access to the supeclass and thus couldn't be implemented for the local implementations of the processing calls. Also removes the last usage (besides live scrolling) of custom update in the DataTable.
        Hide
        Nils Lundquist added a comment -

        These are already available as client behaviours of the parent data table. 'expand' / 'contract'.

        While I admit it would be more logical to have these events on the expansion toggle component rather than the table, the expansion toggler doesn't render any javascript of its own, it has its events bound by the data table at table setup. So the table was the most convenient place to add the ace:ajax client behaviours. Having them on the expansion toggle would require large refactors to the expansion request lifecycle.

        Show
        Nils Lundquist added a comment - These are already available as client behaviours of the parent data table. 'expand' / 'contract'. While I admit it would be more logical to have these events on the expansion toggle component rather than the table, the expansion toggler doesn't render any javascript of its own, it has its events bound by the data table at table setup. So the table was the most convenient place to add the ace:ajax client behaviours. Having them on the expansion toggle would require large refactors to the expansion request lifecycle.

          People

          • Assignee:
            Nils Lundquist
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: