ICEfaces
  1. ICEfaces
  2. ICE-7344

Session Expired responses received but not displayed.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1-Beta
    • Fix Version/s: 2.1-Beta2, 3.0
    • Component/s: Bridge
    • Labels:
      None
    • Environment:
      ICEfaces 2 Auction AuctionMonitor MyFaces Mojarra
    • Assignee Priority:
      P2

      Description

      In testing the Auction example with MyFaces, I noticed that when the session expired, I was receiving the proper response from the push requests:

      <?xml version='1.0' encoding='UTF-8'?>
          <partial-response>
              <error>
                  <error-name>class org.icefaces.application.SessionExpiredException</error-name>
                  <error-message><![CDATA[Session has expired]]></error-message>
              </error>
          </partial-response>

      but it was not popping up a notification on the client nor was it shutting down push. Push would keep running and returning the SessionExpiredException over and over.

      I set some breakpoints at various points in the bridge.js code to see where it might be breaking down but it doesn't appear that the following function is being called at all:

              function filterICEfacesEvents(f) {...

      which suggests that the callback is not being called for some reason:

              jsf.ajax.addOnError(filterICEfacesEvents(submitErrorBroadcaster(networkErrorListeners, serverErrorListeners)));

        Issue Links

          Activity

          Hide
          Deryk Sinotte added a comment -

          This is a regression as it does not happen in the 2.1 beta release - the Session Expiry dialog popups up properly.

          Show
          Deryk Sinotte added a comment - This is a regression as it does not happen in the 2.1 beta release - the Session Expiry dialog popups up properly.
          Hide
          Mircea Toma added a comment -

          The filterICEfacesEvens() functions filters out the server error partial updates because these events are not preceded by the 'begin' event during which the ICEfaces enabled detection is made. Because of this the onServerError callbacks are not invoked, including the session expired popup.

          Show
          Mircea Toma added a comment - The filterICEfacesEvens() functions filters out the server error partial updates because these events are not preceded by the 'begin' event during which the ICEfaces enabled detection is made. Because of this the onServerError callbacks are not invoked, including the session expired popup.
          Hide
          Mircea Toma added a comment -

          Changed filterICEfacesEvents() function to detect ICEfaces enabled forms also when server error partial updates are received.

          Show
          Mircea Toma added a comment - Changed filterICEfacesEvents() function to detect ICEfaces enabled forms also when server error partial updates are received.
          Hide
          Deryk Sinotte added a comment -

          I retested with Mojarra and MyFaces and this looks to be corrected now.

          Show
          Deryk Sinotte added a comment - I retested with Mojarra and MyFaces and this looks to be corrected now.
          Hide
          Xabier Pastor added a comment -

          I´m afraid that this occurs again in 3.1.0 version.

          Show
          Xabier Pastor added a comment - I´m afraid that this occurs again in 3.1.0 version.

            People

            • Assignee:
              Mircea Toma
              Reporter:
              Deryk Sinotte
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: