ICEfaces
  1. ICEfaces
  2. ICE-7171

Support for downloading file as an attachment in <ice:outputResource> component

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0.2
          • Fix Version/s: 2.1-Beta, 3.0
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            N/A

            Description

            In ICEFaces 2.0.2 <ice:outputResource> behavior has changed.

            In 1.8.x 'save file/open file' options dialog was appearing in browser when clicking on the link generated by the component. Now the file is opened right away in a new browser tab which is not always suitable (there is an option of right-clicking on the link and selecting 'save link as...' but this option is not clear for end users - taking into account that they got used to the old behavior).

            Comparing HTTP response headers for <ice:outputResource> in ICEFaces 1.8 and 2.0 you can see that there is a header in 1.8 which is missing in 2.0:

            <code>
            Content-Disposition attachment; filename="/opt/testfile.txt"
            <code>

              Activity

              Ascending order - Click to sort in descending order
              Mikhail Vasilko created issue -
              Ken Fyten made changes -
              Field Original Value New Value
              Salesforce Case []
              Fix Version/s 2.1 [ 10241 ]
              Assignee Priority P2
              Assignee Adnan Durrani [ adnan.durrani ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #25423 Wed Sep 07 23:29:08 MDT 2011 adnan.durrani Fix for ICE-7171 (Support for downloading file as an attachment in <ice:outputResource> component )
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/util/Util.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/outputresource/OutputResource.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/push/DynamicResourceDispatcher.java
              Adnan Durrani made changes -
              Status Open [ 1 ] In Progress [ 3 ]
              Hide
              Permalink
              Adnan Durrani added a comment -

              Command: Commit
              Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\outputresource\OutputResource.java
              Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\push\DynamicResourceDispatcher.java
              Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\util\Util.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\push\DynamicResourceDispatcher.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\outputresource\OutputResource.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\util\Util.java
              Completed: At revision: 25423

              Show
              Adnan Durrani added a comment - Command: Commit Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\outputresource\OutputResource.java Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\push\DynamicResourceDispatcher.java Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\util\Util.java Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\push\DynamicResourceDispatcher.java Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\outputresource\OutputResource.java Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\util\Util.java Completed: At revision: 25423
              Adnan Durrani made changes -
              Status In Progress [ 3 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #25426 Thu Sep 08 08:39:47 MDT 2011 yip.ng ICE-7171: Reverted for now. Caused build failures.
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/util/Util.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/outputresource/OutputResource.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/push/DynamicResourceDispatcher.java
              Hide
              Permalink
              yip.ng added a comment -

              Backed out for now. Caused build failures.

              Show
              yip.ng added a comment - Backed out for now. Caused build failures.
              yip.ng made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #25436 Thu Sep 08 21:12:35 MDT 2011 adnan.durrani Fix for ICE-7171 (Support for downloading file as an attachment in <ice:outputResource> component ) with build fix
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/util/Util.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/outputresource/OutputResource.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/push/DynamicResourceDispatcher.java
              Hide
              Permalink
              Adnan Durrani added a comment -

              Fixed the build.

              Command: Commit
              Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\outputresource\OutputResource.java
              Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\push\DynamicResourceDispatcher.java
              Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\util\Util.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\push\DynamicResourceDispatcher.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\outputresource\OutputResource.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\util\Util.java
              Completed: At revision: 25436

              Show
              Adnan Durrani added a comment - Fixed the build. Command: Commit Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\outputresource\OutputResource.java Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\push\DynamicResourceDispatcher.java Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\util\Util.java Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\push\DynamicResourceDispatcher.java Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\outputresource\OutputResource.java Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\util\Util.java Completed: At revision: 25436
              Adnan Durrani made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 2.1-Beta [ 10291 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Adnan Durrani
                  Reporter:
                  Mikhail Vasilko
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: