ICEfaces
  1. ICEfaces
  2. ICE-7171

Support for downloading file as an attachment in <ice:outputResource> component

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.2
    • Fix Version/s: 2.1-Beta, 3.0
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      N/A

      Description

      In ICEFaces 2.0.2 <ice:outputResource> behavior has changed.

      In 1.8.x 'save file/open file' options dialog was appearing in browser when clicking on the link generated by the component. Now the file is opened right away in a new browser tab which is not always suitable (there is an option of right-clicking on the link and selecting 'save link as...' but this option is not clear for end users - taking into account that they got used to the old behavior).

      Comparing HTTP response headers for <ice:outputResource> in ICEFaces 1.8 and 2.0 you can see that there is a header in 1.8 which is missing in 2.0:

      <code>
      Content-Disposition attachment; filename="/opt/testfile.txt"
      <code>

        Activity

        Hide
        Adnan Durrani added a comment -

        Command: Commit
        Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\outputresource\OutputResource.java
        Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\push\DynamicResourceDispatcher.java
        Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\util\Util.java
        Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\push\DynamicResourceDispatcher.java
        Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\outputresource\OutputResource.java
        Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\util\Util.java
        Completed: At revision: 25423

        Show
        Adnan Durrani added a comment - Command: Commit Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\outputresource\OutputResource.java Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\push\DynamicResourceDispatcher.java Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\util\Util.java Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\push\DynamicResourceDispatcher.java Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\outputresource\OutputResource.java Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\util\Util.java Completed: At revision: 25423
        Hide
        yip.ng added a comment -

        Backed out for now. Caused build failures.

        Show
        yip.ng added a comment - Backed out for now. Caused build failures.
        Hide
        Adnan Durrani added a comment -

        Fixed the build.

        Command: Commit
        Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\outputresource\OutputResource.java
        Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\push\DynamicResourceDispatcher.java
        Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\util\Util.java
        Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\push\DynamicResourceDispatcher.java
        Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\outputresource\OutputResource.java
        Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\util\Util.java
        Completed: At revision: 25436

        Show
        Adnan Durrani added a comment - Fixed the build. Command: Commit Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\outputresource\OutputResource.java Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\push\DynamicResourceDispatcher.java Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\util\Util.java Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\push\DynamicResourceDispatcher.java Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\outputresource\OutputResource.java Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\core\src\main\java\org\icefaces\impl\util\Util.java Completed: At revision: 25436

          People

          • Assignee:
            Adnan Durrani
            Reporter:
            Mikhail Vasilko
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: