ICEfaces
  1. ICEfaces
  2. ICE-7070

FacesMessagesPhaseListener should only save if there's actually something to save

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-2.0.0.GA, 2.0.2
          • Fix Version/s: 2.1-Beta, 3.0
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            ICEfaces

            Description

            FacesMessagesPhaseListener should only save if there's actually something to save, that is only if the globals and/or the components collection are not empty.

              Activity

              Ascending order - Click to sort in descending order
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #25060 Thu Jul 21 11:58:53 MDT 2011 jack.van.ooststroom Fixed JIRA ICE-7070 : FacesMessagesPhaseListener should only save if there's actually something to save
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/FacesMessagesPhaseListener.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #25061 Thu Jul 21 12:00:00 MDT 2011 jack.van.ooststroom Fixed JIRA ICE-7070 : FacesMessagesPhaseListener should only save if there's actually something to save; Oops... checked in too much
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/FacesMessagesPhaseListener.java
              Jack Van Ooststroom created issue -
              Jack Van Ooststroom made changes -
              Field Original Value New Value
              Assignee Jack van Ooststroom [ jack.van.ooststroom ]
              Jack Van Ooststroom made changes -
              Salesforce Case []
              Fix Version/s 2.1 [ 10241 ]
              Fix Version/s EE-2.1.0 [ 10262 ]
              Jack Van Ooststroom made changes -
              Status Open [ 1 ] In Progress [ 3 ]
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Added two simple checks:

              if (!globals.isEmpty())

              { facesContext.getViewRoot().getAttributes().put( SAVED_GLOBAL_FACES_MESSAGES_KEY, globals); }

              if (!components.isEmpty())

              { facesContext.getViewRoot().getAttributes().put( SAVED_COMPONENT_FACES_MESSAGES_KEY, components); }

              Marking this one as FIXED.

              Show
              Jack Van Ooststroom added a comment - Added two simple checks: if (!globals.isEmpty()) { facesContext.getViewRoot().getAttributes().put( SAVED_GLOBAL_FACES_MESSAGES_KEY, globals); } if (!components.isEmpty()) { facesContext.getViewRoot().getAttributes().put( SAVED_COMPONENT_FACES_MESSAGES_KEY, components); } Marking this one as FIXED.
              Jack Van Ooststroom made changes -
              Status In Progress [ 3 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 2.1-Beta [ 10291 ]
              Fix Version/s EE-2.1.0 [ 10262 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Jack Van Ooststroom
                  Reporter:
                  Jack Van Ooststroom
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: