ICEfaces
  1. ICEfaces
  2. ICE-7070

FacesMessagesPhaseListener should only save if there's actually something to save

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-2.0.0.GA, 2.0.2
    • Fix Version/s: 2.1-Beta, 3.0
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      ICEfaces

      Description

      FacesMessagesPhaseListener should only save if there's actually something to save, that is only if the globals and/or the components collection are not empty.

        Activity

        Hide
        Jack Van Ooststroom added a comment -

        Added two simple checks:

        if (!globals.isEmpty())

        { facesContext.getViewRoot().getAttributes().put( SAVED_GLOBAL_FACES_MESSAGES_KEY, globals); }

        if (!components.isEmpty())

        { facesContext.getViewRoot().getAttributes().put( SAVED_COMPONENT_FACES_MESSAGES_KEY, components); }

        Marking this one as FIXED.

        Show
        Jack Van Ooststroom added a comment - Added two simple checks: if (!globals.isEmpty()) { facesContext.getViewRoot().getAttributes().put( SAVED_GLOBAL_FACES_MESSAGES_KEY, globals); } if (!components.isEmpty()) { facesContext.getViewRoot().getAttributes().put( SAVED_COMPONENT_FACES_MESSAGES_KEY, components); } Marking this one as FIXED.

          People

          • Assignee:
            Jack Van Ooststroom
            Reporter:
            Jack Van Ooststroom
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: