[ICE-7029] Nested DataTable Testing Failures - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.0.RC1
Fix Version/s: 3.0.RC1, 3.0
Component/s: ACE-Components
Labels:
None
Environment:
2.1 Nested Datatable Test, Tomcat 6

Assignee Priority:
P1

Description

This JIRA captures explanations and exploration of fixes for bugs observed while the running and developing table-nesting tests.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

Hide
Case10547Example.war

11/Oct/11 10:32 AM

7.39 MB

Arran Mccullough
META-INF/MANIFEST.MF 0.1 kB

META-INF/context.xml 0.1 kB

WEB-INF/classes/com/.../example/Child.class 2 kB

WEB-INF/classes/com/.../example/Item.class 0.8 kB

WEB-INF/classes/com/.../example/Parent.class 1 kB

WEB-INF/classes/.../example/TestBean.class 0.9 kB

WEB-INF/lib/commons-beanutils.jar 226 kB

WEB-INF/lib/commons-collections.jar 558 kB

WEB-INF/lib/commons-digester.jar 140 kB

WEB-INF/lib/commons-logging.jar 52 kB

WEB-INF/lib/icefaces-ace.jar 1.42 MB

WEB-INF/lib/icefaces-compat.jar 2.29 MB

WEB-INF/lib/icefaces.jar 237 kB

WEB-INF/lib/javax.faces.jar 2.48 MB

WEB-INF/web.xml 2 kB

welcomeICEfaces.xhtml 3 kB

Download Zip
Show

Case10547Example.war

11/Oct/11 10:32 AM

7.39 MB

Arran Mccullough
Hide
Case10547Example.zip

11/Oct/11 10:32 AM

19 kB

Arran Mccullough
Case10547Example/build.xml 3 kB

Case10547Example/.../ant-deploy.xml 2 kB

Case10547Example/.../build-impl.xml 58 kB

Case10547Example/.../genfiles.properties 0.5 kB

Case10547Example/.../private.properties 0.5 kB

Case10547Example/nbproject/.../private.xml 0.2 kB

Case10547Example/.../project.properties 3 kB

Case10547Example/nbproject/project.xml 0.9 kB

Case10547Example/src/conf/MANIFEST.MF 0.0 kB

Case10547Example/src/.../example/Child.java 1 kB

Case10547Example/src/.../example/Item.java 0.6 kB

Case10547Example/src/.../example/Parent.java 1 kB

Case10547Example/src/.../TestBean.java 0.7 kB

Case10547Example/web/.../context.xml 0.1 kB

Case10547Example/web/WEB-INF/web.xml 2 kB

Case10547Example/.../welcomeICEfaces.xhtml 3 kB

Download Zip
Show

Case10547Example.zip

11/Oct/11 10:32 AM

19 kB

Arran Mccullough
DataTable.java

05/Oct/11 6:30 PM

32 kB

Nils Lundquist
nesting_fix_-_patches_25836.patch

05/Oct/11 6:30 PM

8 kB

Nils Lundquist
UIData.java

05/Oct/11 6:30 PM

2 kB

Nils Lundquist

nested-datatable-issue1.JPG

76 kB

11/Oct/11 10:34 AM
nested-datatable-issue2.JPG

89 kB

11/Oct/11 10:34 AM
nested-datatable-issue3.JPG

112 kB

11/Oct/11 10:34 AM

Issue Links

blocks

ICE-6997 New ace:dataTable Component

Closed

Activity

Ascending order - Click to sort in descending order

Nils Lundquist created issue - 07/Jul/11 4:06 PM

Nils Lundquist made changes - 07/Jul/11 4:07 PM

Field	Original Value	New Value
Link		This issue blocks ~~ICE-6997~~ [ ~~ICE-6997~~ ]

Hide

Permalink

Nils Lundquist added a comment - 07/Jul/11 4:21 PM

First problem presenting in the test, are pagination buttons of a nested that either have no event bound, or whose responses perform no updates. Both are present in the current test.

Show

Nils Lundquist added a comment - 07/Jul/11 4:21 PM First problem presenting in the test, are pagination buttons of a nested that either have no event bound, or whose responses perform no updates. Both are present in the current test.

Ken Fyten made changes - 26/Sep/11 10:43 AM

Component/s		ACE-Components [ 10050 ]
Fix Version/s		2.1-Beta [ 10291 ]
Affects Version/s		2.1-Beta [ 10291 ]
Assignee		Nils Lundquist [ nils.lundquist ]

Ken Fyten made changes - 26/Sep/11 10:46 AM

Salesforce Case		[]
Assignee Priority		P1

Ken Fyten made changes - 05/Oct/11 11:50 AM

Fix Version/s		2.1 [ 10241 ]
Fix Version/s	2.1-Beta [ 10291 ]

Hide

Permalink

Nils Lundquist added a comment - 05/Oct/11 6:30 PM

Added patch as well as whole files in case patch doesn't apply correctly.

Show

Nils Lundquist added a comment - 05/Oct/11 6:30 PM Added patch as well as whole files in case patch doesn't apply correctly.

Nils Lundquist made changes - 05/Oct/11 6:30 PM

Attachment		nesting_fix_-_patches_25836.patch [ 13620 ]
Attachment		DataTable.java [ 13621 ]
Attachment		UIData.java [ 13622 ]

Ken Fyten made changes - 07/Oct/11 4:28 PM

Comment

[ After this patch is applied, the value of 'first' doesn't persist between the end of RenderResponse and the start of the next RestoreView.

This breaks pagination. Pagination subsequent visitTree iterations will occur only for the first (and incorrect) page. This is because first is defaulting to 0 after being the correct value in the RenderResponse phase of the previous pagination

The easiest way to see this is an example that includes editing and pagination, and noting that the editing feature works on the first page, but editing on the second page produces no change. ]

Hide

Permalink

Ken Fyten added a comment - 07/Oct/11 4:29 PM

Committed patch - resolved.

Show

Ken Fyten added a comment - 07/Oct/11 4:29 PM Committed patch - resolved.

Ken Fyten made changes - 07/Oct/11 4:29 PM

Status	Open [ 1 ]	Resolved [ 5 ]
Assignee Priority	P1
Resolution		Fixed [ 1 ]

Arran Mccullough made changes - 11/Oct/11 10:31 AM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Hide

Permalink

Arran Mccullough added a comment - 11/Oct/11 10:32 AM

Attached test case war file and source code that demonstrates issues seen in using a nested dataTable using the 10072011 release.

Show

Arran Mccullough added a comment - 11/Oct/11 10:32 AM Attached test case war file and source code that demonstrates issues seen in using a nested dataTable using the 10072011 release.

Arran Mccullough made changes - 11/Oct/11 10:32 AM

Attachment		Case10547Example.zip [ 13646 ]
Attachment		Case10547Example.war [ 13647 ]

Hide

Permalink

Arran Mccullough added a comment - 11/Oct/11 10:34 AM

Description of screen shots of issues:

nested-datatable-issue1.jpg: This shows the rendering of the nested table in the parent table.
nested-datatable-issue2.jpg: After click of the parent expansion toggler
nested-datatable-issue3.jpg: After click of the nested table expansion toggler

Show

Arran Mccullough added a comment - 11/Oct/11 10:34 AM Description of screen shots of issues: nested-datatable-issue1.jpg: This shows the rendering of the nested table in the parent table. nested-datatable-issue2.jpg: After click of the parent expansion toggler nested-datatable-issue3.jpg: After click of the nested table expansion toggler

Arran Mccullough made changes - 11/Oct/11 10:34 AM

Attachment		nested-datatable-issue1.JPG [ 13648 ]
Attachment		nested-datatable-issue2.JPG [ 13649 ]
Attachment		nested-datatable-issue3.JPG [ 13650 ]

Ken Fyten made changes - 13/Oct/11 1:08 PM

Salesforce Case		[]
Assignee Priority		P1

Hide

Permalink

Nils Lundquist added a comment - 19/Oct/11 2:01 PM

This issue was intended for issues regarding a data table nested in a column of the parent, rather than in a panelExpansion. The two cases are somewhat different.

This issue has been resolved however. Several minor JS bugs, a getColumns() bug and unimplemented functionality in visitTree were responsible.

Fixes committed in r25971.

Show

Nils Lundquist added a comment - 19/Oct/11 2:01 PM This issue was intended for issues regarding a data table nested in a column of the parent, rather than in a panelExpansion. The two cases are somewhat different. This issue has been resolved however. Several minor JS bugs, a getColumns() bug and unimplemented functionality in visitTree were responsible. Fixes committed in r25971.

Nils Lundquist made changes - 19/Oct/11 2:01 PM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Ken Fyten made changes - 28/Oct/11 4:55 PM

Fix Version/s

2.1-Beta2 [ 10294 ]

Ken Fyten made changes - 03/Nov/11 1:37 PM

Security

Private [ 10001 ]

Hide

Permalink

Nils Lundquist added a comment - 16/Nov/11 4:41 PM

The nested table is currently experiencing issues in partial visits.

Show

Nils Lundquist added a comment - 16/Nov/11 4:41 PM The nested table is currently experiencing issues in partial visits.

Nils Lundquist made changes - 16/Nov/11 4:41 PM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Ken Fyten made changes - 29/Nov/11 6:10 PM

Salesforce Case		[]
Fix Version/s		3.0.RC1 [ 10300 ]
Fix Version/s	2.1-Beta2 [ 10294 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#26651	Wed Nov 30 13:27:06 MST 2011	nils.lundquist	~~ICE-7029~~ - Fixes for nested data table issues. Fixed issues related to out of sync data model, overly broad javascript selectors, clientId assignment, generator property getter bug for mojarra-style UIData clientIds. Iterate for table has also been narrowed. State saving issue for child data table remains. Workaround is to bind to a bean the properties of the child table.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTable.java MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/artifacts/ComponentArtifact.java MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRenderer.java MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js

Hide

Permalink

Nils Lundquist added a comment - 30/Nov/11 3:39 PM

r26651 - Fixes for nested data table issues.

Fixed issues related to out of sync data model, overly broad javascript selectors, clientId assignment, generator property getter bug for mojarra-style UIData clientIds. Iterate for table has also been narrowed.

State saving issue for child data table remains. Workaround is to bind to a bean the properties of the child table.

Show

Nils Lundquist added a comment - 30/Nov/11 3:39 PM r26651 - Fixes for nested data table issues. Fixed issues related to out of sync data model, overly broad javascript selectors, clientId assignment, generator property getter bug for mojarra-style UIData clientIds. Iterate for table has also been narrowed. State saving issue for child data table remains. Workaround is to bind to a bean the properties of the child table.

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#26687	Thu Dec 01 13:51:57 MST 2011	nils.lundquist	~~ICE-7029~~ - Added spacing on getComponentId() generated method.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/artifacts/ComponentArtifact.java

Ken Fyten made changes - 02/Dec/11 2:43 PM

Fix Version/s	3.0.RC1 [ 10300 ]
Affects Version/s		3.0.RC1 [ 10300 ]
Affects Version/s	2.1-Beta [ 10291 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#26729	Fri Dec 02 15:36:56 MST 2011	nils.lundquist	~~ICE-7029~~ - Adjusted DataTable to generate properties while rowIndex == -1. Else properties are saved with the wrong clientId and are not correctly restored / retrieved. DataTable visitTree has also been altered to properly visit column children during non-iterative "row" visiting.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTable.java MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/artifacts/ComponentArtifact.java MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRenderer.java

Hide

Permalink

Nils Lundquist added a comment - 05/Dec/11 11:36 AM

State saving problem caused by broken visitTree impl; not visiting column children during non-iterative visits correctly.

Getter refactoring was reverted given that it was the incorrect solution to the problem of StateMap being loaded when getClientId() was unreliable.

Show

Nils Lundquist added a comment - 05/Dec/11 11:36 AM State saving problem caused by broken visitTree impl; not visiting column children during non-iterative visits correctly. Getter refactoring was reverted given that it was the incorrect solution to the problem of StateMap being loaded when getClientId() was unreliable.

Nils Lundquist made changes - 05/Dec/11 11:36 AM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Fix Version/s		3.0.RC1 [ 10300 ]
Fix Version/s	3.0 [ 10241 ]
Resolution		Fixed [ 1 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#26744	Mon Dec 05 14:40:51 MST 2011	nils.lundquist	~~ICE-7029~~ - Fix for DataTable Nesting without StateMap Caching
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTable.java MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRenderer.java

Ken Fyten made changes - 06/Feb/12 12:55 PM

Fix Version/s

3.0 [ 10241 ]

Ken Fyten made changes - 13/Feb/12 4:32 PM

Status

Resolved [ 5 ]

Closed [ 6 ]

People

Assignee:

Nils Lundquist

Reporter:

Nils Lundquist

Votes:

0 Vote for this issue

Watchers:

1 Start watching this issue

Dates

Created:

07/Jul/11 4:06 PM

Updated:

13/Feb/12 4:32 PM

Resolved:

05/Dec/11 11:36 AM