ICEfaces
  1. ICEfaces
  2. ICE-6961

Re-enable animations for ace:tabSet

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.2
    • Fix Version/s: 2.1-Beta2, 3.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ACE
    • Assignee Priority:
      P2

      Description

      With ICE-6728, we disabled animations for changing tabs with the tabSet component. As well, we're looking at revamping our animation support in general, so we've decided to defer the effort for re-enabling that feature.

        Issue Links

          Activity

          Hide
          Mark Collette added a comment -

          In the old code tabSet javascript code, we would hook into the tabSet's tab change listener's submit listener, to do some processing after the server had rendered the new tab content. So we'd have both the old tab and the new tab available for doing animations on. With the new code, it uses an ondomready call that defers the processing of the new tab contents until after the submit listener would have been invoked. This means that we don't have that simple place to access both tabs for animations. Possibly we'll need to do the animation for hiding the old tab, and then do the submit, and then do the animation for showing the new tab.

          Show
          Mark Collette added a comment - In the old code tabSet javascript code, we would hook into the tabSet's tab change listener's submit listener, to do some processing after the server had rendered the new tab content. So we'd have both the old tab and the new tab available for doing animations on. With the new code, it uses an ondomready call that defers the processing of the new tab contents until after the submit listener would have been invoked. This means that we don't have that simple place to access both tabs for animations. Possibly we'll need to do the animation for hiding the old tab, and then do the submit, and then do the animation for showing the new tab.
          Hide
          Ken Fyten added a comment - - edited

          Need to integrate the new ace:animations (based on jquery effects) with ace:tabSet.

          This can take the form of adding showEffect/hideEffect attributes to the ace:tabSet (for showing/hiding the tabpane when selected/deselected). Also add showEffectLength/hideEffectLength attributes like we have with ace:tooltip.

          Show
          Ken Fyten added a comment - - edited Need to integrate the new ace:animations (based on jquery effects) with ace:tabSet. This can take the form of adding showEffect/hideEffect attributes to the ace:tabSet (for showing/hiding the tabpane when selected/deselected). Also add showEffectLength/hideEffectLength attributes like we have with ace:tooltip.

            People

            • Assignee:
              Arturo Zambrano
              Reporter:
              Mark Collette
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: