ICEfaces
  1. ICEfaces
  2. ICE-6932

Fix modal popup centering within visible viewport

          Details

          • Assignee Priority:
            P2

            Description

            Modal popup is centered based on the entire browser area including the non-visible area. So if the portal page has enough portlets or very large portlets, the modal popup is displayed offscreen (down past the bottom of the browser). The non-modal/draggable doesn't have this issue when auto-centered is turned on.

              Activity

              Ascending order - Click to sort in descending order
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24762 Mon Jun 06 05:40:13 MDT 2011 mircea.toma ICE-6932 Center modal popup using visible viewport dimensions and the scroll offsets.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/style.js
              Mircea Toma created issue -
              Hide
              Permalink
              Mircea Toma added a comment -

              Deryk said:
              "I confirmed that this is not portal specific. I added a bunch of dummy content to the bottom of the page-template.jspx file to make it fill a couple of screens worth and trigger the appearance of a scroll bar. Then when I ran the non-portlet version of Component Showcase and chose the Popup Panel example - it behaved the same way:

              http://dl.dropbox.com/u/14124/Screenshots/panelpopup-top.png
              http://dl.dropbox.com/u/14124/Screenshots/panelpopup-scrolled.png "

              Show
              Mircea Toma added a comment - Deryk said: "I confirmed that this is not portal specific. I added a bunch of dummy content to the bottom of the page-template.jspx file to make it fill a couple of screens worth and trigger the appearance of a scroll bar. Then when I ran the non-portlet version of Component Showcase and chose the Popup Panel example - it behaved the same way: http://dl.dropbox.com/u/14124/Screenshots/panelpopup-top.png http://dl.dropbox.com/u/14124/Screenshots/panelpopup-scrolled.png "
              Mircea Toma made changes -
              Field Original Value New Value
              Assignee Mircea Toma [ mircea.toma ]
              Hide
              Permalink
              Mircea Toma added a comment -

              The fix changed the modal offset calculations by using the visible viewport dimensions and the scroll offsets to properly center the popup even when the page is scrolled.

              Show
              Mircea Toma added a comment - The fix changed the modal offset calculations by using the visible viewport dimensions and the scroll offsets to properly center the popup even when the page is scrolled.
              Mircea Toma made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Ken Fyten added a comment -

              Need to apply this same calc. change to the 2.x versions.

              Show
              Ken Fyten added a comment - Need to apply this same calc. change to the 2.x versions.
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Assignee Priority P2
              Ken Fyten made changes -
              Salesforce Case []
              Fix Version/s EE-2.0.0.GA_P01 [ 10271 ]
              Fix Version/s 2.1 [ 10241 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24777 Wed Jun 08 14:38:49 MDT 2011 mircea.toma ICE-6932 Changed the modal offset calculations by using the visible viewport dimensions and the scroll offsets to properly center the popup even when the page is scrolled.
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/javascript/extras/extras.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24778 Wed Jun 08 14:47:52 MDT 2011 mircea.toma ICE-6932 Changed the modal offset calculations by using the visible viewport dimensions and the scroll offsets to properly center the popup even when the page is scrolled.
              Files Changed
              Commit graph MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/compat/core/src/main/javascript/extras/extras.js
              Hide
              Permalink
              Mircea Toma added a comment -

              Applied fix to ICEfaces2 trunk and 2.0.x maintenance branch.

              Show
              Mircea Toma added a comment - Applied fix to ICEfaces2 trunk and 2.0.x maintenance branch.
              Mircea Toma made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 2.1-Beta [ 10291 ]
              Fix Version/s 2.1 [ 10241 ]
              Ken Fyten made changes -
              Fix Version/s 3.0 [ 10241 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Mircea Toma
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: