ICEfaces
  1. ICEfaces
  2. ICE-6932

Fix modal popup centering within visible viewport

    Details

    • Assignee Priority:
      P2

      Description

      Modal popup is centered based on the entire browser area including the non-visible area. So if the portal page has enough portlets or very large portlets, the modal popup is displayed offscreen (down past the bottom of the browser). The non-modal/draggable doesn't have this issue when auto-centered is turned on.

        Activity

        Hide
        Mircea Toma added a comment -

        Deryk said:
        "I confirmed that this is not portal specific. I added a bunch of dummy content to the bottom of the page-template.jspx file to make it fill a couple of screens worth and trigger the appearance of a scroll bar. Then when I ran the non-portlet version of Component Showcase and chose the Popup Panel example - it behaved the same way:

        http://dl.dropbox.com/u/14124/Screenshots/panelpopup-top.png
        http://dl.dropbox.com/u/14124/Screenshots/panelpopup-scrolled.png "

        Show
        Mircea Toma added a comment - Deryk said: "I confirmed that this is not portal specific. I added a bunch of dummy content to the bottom of the page-template.jspx file to make it fill a couple of screens worth and trigger the appearance of a scroll bar. Then when I ran the non-portlet version of Component Showcase and chose the Popup Panel example - it behaved the same way: http://dl.dropbox.com/u/14124/Screenshots/panelpopup-top.png http://dl.dropbox.com/u/14124/Screenshots/panelpopup-scrolled.png "
        Hide
        Mircea Toma added a comment -

        The fix changed the modal offset calculations by using the visible viewport dimensions and the scroll offsets to properly center the popup even when the page is scrolled.

        Show
        Mircea Toma added a comment - The fix changed the modal offset calculations by using the visible viewport dimensions and the scroll offsets to properly center the popup even when the page is scrolled.
        Hide
        Ken Fyten added a comment -

        Need to apply this same calc. change to the 2.x versions.

        Show
        Ken Fyten added a comment - Need to apply this same calc. change to the 2.x versions.
        Hide
        Mircea Toma added a comment -

        Applied fix to ICEfaces2 trunk and 2.0.x maintenance branch.

        Show
        Mircea Toma added a comment - Applied fix to ICEfaces2 trunk and 2.0.x maintenance branch.

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Mircea Toma
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: