ICEfaces
  1. ICEfaces
  2. ICE-6817

Layout regression with submenu vertical positioning

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.1-Beta, 3.0
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      *

      Description

      The submenus are appearing too high vertically vs. the root menuitem that opens them. See screenshot 1, from Firefox 4.
      1. screenshot-01.png
        152 kB
      2. screenshot-02.png
        220 kB
      3. screenshot-03.png
        125 kB
      4. screenshot-04.png
        235 kB
      5. screenshot-05.png
        226 kB
      6. screenshot-06.png
        245 kB

        Activity

        Hide
        yip.ng added a comment -

        Same in IE 9 and Chrome 10.

        Show
        yip.ng added a comment - Same in IE 9 and Chrome 10.
        Hide
        yip.ng added a comment -

        There is extra white gap at the top of the page. This gap seems to be the same height as the vertical menu offset and could be the real cause of the problem. See screenshot 2.

        Show
        yip.ng added a comment - There is extra white gap at the top of the page. This gap seems to be the same height as the vertical menu offset and could be the real cause of the problem. See screenshot 2.
        Hide
        yip.ng added a comment -

        Problem doesn't occur in ICEfaces 1.8. See screenshot 3.

        Show
        yip.ng added a comment - Problem doesn't occur in ICEfaces 1.8. See screenshot 3.
        Hide
        yip.ng added a comment -

        Problem caused by the extra message div at the bottom of the page. See screenshot 4.

        Show
        yip.ng added a comment - Problem caused by the extra message div at the bottom of the page. See screenshot 4.
        Hide
        Ken Fyten added a comment -

        Need to test this with PROJECT_STAGE="Production" to see that without the white band caused by the dynamic introduction of the messages component that all is well.

        If that's true, then check to see if the same issue occurs when h:messages are included on the page (in the markup), or whether this only occurs when JSF injects it onto the page for PROJECT_STAGE="Development".

        And investigate the duplicate ID issue to see that it's not a problem with our own h:message and h:messages renderers.

        Show
        Ken Fyten added a comment - Need to test this with PROJECT_STAGE="Production" to see that without the white band caused by the dynamic introduction of the messages component that all is well. If that's true, then check to see if the same issue occurs when h:messages are included on the page (in the markup), or whether this only occurs when JSF injects it onto the page for PROJECT_STAGE="Development". And investigate the duplicate ID issue to see that it's not a problem with our own h:message and h:messages renderers.
        Hide
        yip.ng added a comment - - edited

        No extra div or white band when PROJECT_STAGE="Production" and all is well.

        No problem when using <h:messages/>. See screenshot 5.

        Show
        yip.ng added a comment - - edited No extra div or white band when PROJECT_STAGE="Production" and all is well. No problem when using <h:messages/>. See screenshot 5.
        Hide
        yip.ng added a comment -

        MessagesRenderer changed. See screenshot 6. No change in MessageRenderer needed because message is just a span, not a table or list.

        Revision: 24458


        Modified : /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/renderkit/html_basic/MessagesRenderer.java

        Show
        yip.ng added a comment - MessagesRenderer changed. See screenshot 6. No change in MessageRenderer needed because message is just a span, not a table or list. Revision: 24458 Modified : /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/renderkit/html_basic/MessagesRenderer.java

          People

          • Assignee:
            yip.ng
            Reporter:
            yip.ng
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: