[ICE-6705] ice:selectInputText minChars does not work - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.0.0, EE-1.8.2.GA_P04, 3.1
Fix Version/s: 3.2, EE-1.8.2.GA_P05
Component/s: ICE-Components
Labels:
None
Environment:
Ubuntu 10.10, Eclipse Helios, Dynamic Web Project deployed under JBoss 6.0 Final

Description

minChars option in h:selectInputText element does not work at all.
I created a componenent:
<ice:selectInputText rows="6" width="300"
listVar="comune"
options="{minChars:3}"
valueChangeListener="#{myBean.updateList}"
listValue="#{myBean.listComuni}">
...
</ice:selectInputText>

but the method updateList() is called also with just one character

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

Hide
Case11568Example.war

23/Aug/12 10:50 AM

7.55 MB

Arran Mccullough
META-INF/MANIFEST.MF 0.1 kB

META-INF/context.xml 0.1 kB

WEB-INF/classes/.../AutoCompleteBean.class 4 kB

WEB-INF/.../AutoCompleteDictionary$1.class 1 kB

WEB-INF/.../AutoCompleteDictionary.class 4 kB

WEB-INF/classes/.../autocomplete/City.class 2 kB

WEB-INF/faces-config.xml 1 kB

WEB-INF/lib/FastInfoset.jar 281 kB

WEB-INF/lib/backport-util-concurrent.jar 316 kB

WEB-INF/lib/commons-beanutils.jar 113 kB

WEB-INF/lib/commons-collections.jar 162 kB

WEB-INF/lib/commons-digester.jar 104 kB

WEB-INF/lib/commons-fileupload.jar 56 kB

WEB-INF/lib/commons-logging.jar 30 kB

WEB-INF/lib/icefaces-comps.jar 1.75 MB

WEB-INF/lib/icefaces-facelets.jar 592 kB

WEB-INF/lib/icefaces.jar 1.22 MB

WEB-INF/lib/jsf-api.jar 312 kB

WEB-INF/lib/jsf-impl.jar 1.14 MB

WEB-INF/lib/jstl.jar 20 kB

WEB-INF/lib/jxl.jar 689 kB

WEB-INF/.../krysalis-jCharts-1.0.0-alpha-1.jar 148 kB

WEB-INF/lib/standard.jar 380 kB

WEB-INF/resources/city.xml.zip 293 kB

WEB-INF/web.xml 4 kB

welcomeICEfaces.xhtml 3 kB

Download Zip
Show

Case11568Example.war

23/Aug/12 10:50 AM

7.55 MB

Arran Mccullough
Case11568Example.zip

23/Aug/12 10:50 AM

319 kB

Arran Mccullough

screenshot-01.png

155 kB

05/Sep/12 12:55 PM
screenshot-02.png

255 kB

06/Sep/12 4:16 PM

Activity

Ascending order - Click to sort in descending order

Alessandro Rodi created issue - 28/Mar/11 5:48 AM

Arran Mccullough made changes - 23/Aug/12 10:46 AM

Field	Original Value	New Value
Salesforce Case		[5007000000NJnIT]
Affects Version/s		3.1 [ 10312 ]
Affects Version/s		EE-1.8.2.GA_P04 [ 10280 ]

Hide

Permalink

Arran Mccullough added a comment - 23/Aug/12 10:50 AM

Attached test case that reproduces this issue.

Show

Arran Mccullough added a comment - 23/Aug/12 10:50 AM Attached test case that reproduces this issue.

Arran Mccullough made changes - 23/Aug/12 10:50 AM

Attachment		Case11568Example.war [ 14817 ]
Attachment		Case11568Example.zip [ 14818 ]

Ken Fyten made changes - 30/Aug/12 10:28 AM

Fix Version/s		3.2 [ 10338 ]
Fix Version/s		EE-1.8.2.GA_P05 [ 10331 ]
Assignee Priority		P2
Assignee		yip.ng [ yip.ng ]

yip.ng made changes - 05/Sep/12 12:55 PM

Attachment

screenshot-01.png [ 14861 ]

Hide

Permalink

yip.ng added a comment - 05/Sep/12 12:57 PM - edited

Mysterious TypeError from anonymous function when you start typing. No way to debug. See screenshot-01.png. Same in component showcase. Error line is in bind() function in Prototype JS file lang.js. Need to fix this first.

Show

yip.ng added a comment - 05/Sep/12 12:57 PM - edited Mysterious TypeError from anonymous function when you start typing. No way to debug. See screenshot-01.png. Same in component showcase. Error line is in bind() function in Prototype JS file lang.js. Need to fix this first.

Hide

Permalink

yip.ng added a comment - 05/Sep/12 4:36 PM - edited

Error is caused by: (changes to bridge/lib/event.js)

Revision: 29817, ~~ICE-8038~~

Reverted locally for now to proceed.

Show

yip.ng added a comment - 05/Sep/12 4:36 PM - edited Error is caused by: (changes to bridge/lib/event.js) Revision: 29817, ICE-8038 Reverted locally for now to proceed.

Hide

Permalink

yip.ng added a comment - 05/Sep/12 6:35 PM - edited

Exception in backing bean in test app.:

5-Sep-2012 5:29:36 PM com.icesoft.icefaces.tutorial.component.autocomplete.AutoCompleteBean setMatches
SEVERE: Erorr finding autocomplete matches
java.lang.NullPointerException
at java.util.Collections.binarySearch(Collections.java:306)
at com.icesoft.icefaces.tutorial.component.autocomplete.AutoCompleteBean.setMatches(AutoCompleteBean.java:153)
at com.icesoft.icefaces.tutorial.component.autocomplete.AutoCompleteBean.updateList(AutoCompleteBean.java:77)

Tried debugging and fixing. Time-consuming. Don't want to waste any more time on it. Use component showcase instead for testing.

Show

yip.ng added a comment - 05/Sep/12 6:35 PM - edited Exception in backing bean in test app.: 5-Sep-2012 5:29:36 PM com.icesoft.icefaces.tutorial.component.autocomplete.AutoCompleteBean setMatches SEVERE: Erorr finding autocomplete matches java.lang.NullPointerException at java.util.Collections.binarySearch(Collections.java:306) at com.icesoft.icefaces.tutorial.component.autocomplete.AutoCompleteBean.setMatches(AutoCompleteBean.java:153) at com.icesoft.icefaces.tutorial.component.autocomplete.AutoCompleteBean.updateList(AutoCompleteBean.java:77) Tried debugging and fixing. Time-consuming. Don't want to waste any more time on it. Use component showcase instead for testing.

Hide

Permalink

yip.ng added a comment - 06/Sep/12 3:37 PM - edited

minChars is set to zero and then ignored to boot by us on purpose. The original Scriptaculous code doesn't have such logic. See screenshot-02.png. If we comment out our changes, then it works. See video: http://screencast.com/t/4RYGB5qmd.

Our code dates back to the oldest revisions shown in svn log: (but it seems huge chunks of code were just copied/modified from somewhere else.)

Setting minChars to 0:

Revision: 11998
Author: mircea
Date: November-13-06 3:36:00 PM
Message: Fix potential memory leak.

Ignoring minChars in making calls to update:

Revision: 13146
Author: rmayhew
Date: February-06-07 3:30:09 PM
Message: Autocomplete fixed. IRAP 1300

Show

yip.ng added a comment - 06/Sep/12 3:37 PM - edited minChars is set to zero and then ignored to boot by us on purpose. The original Scriptaculous code doesn't have such logic. See screenshot-02.png. If we comment out our changes, then it works. See video: http://screencast.com/t/4RYGB5qmd . Our code dates back to the oldest revisions shown in svn log: (but it seems huge chunks of code were just copied/modified from somewhere else.) Setting minChars to 0: Revision: 11998 Author: mircea Date: November-13-06 3:36:00 PM Message: Fix potential memory leak. Ignoring minChars in making calls to update: Revision: 13146 Author: rmayhew Date: February-06-07 3:30:09 PM Message: Autocomplete fixed. IRAP 1300

yip.ng made changes - 06/Sep/12 4:16 PM

Attachment

screenshot-02.png [ 14867 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#30751	Fri Sep 07 16:05:27 MDT 2012	yip.ng	~~ICE-6705~~: ice:selectInputText minChars does not work.
				Files Changed
				MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/autocomplete_ext.js

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#30755	Fri Sep 07 16:31:51 MDT 2012	yip.ng	~~ICE-6705~~: ice:selectInputText minChars does not work.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/javascript/extras/extras.js

Hide

Permalink

yip.ng added a comment - 07/Sep/12 5:05 PM - edited

Code restored to like originally in Scriptaculous. Error caused by bridge code changes mentioned above (http://jira.icesoft.org/browse/ICE-6705?focusedCommentId=42020&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_42020) still exists. (In 1.8 only. 3.2 seems fine.)

Modified: C:\svn\ossrepo\icefaces\trunk\icefaces\bridge\lib\extras\autocomplete_ext.js
Completed: At revision: 30751

Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\core\src\main\javascript\extras\extras.js
Completed: At revision: 30755

Show

yip.ng added a comment - 07/Sep/12 5:05 PM - edited Code restored to like originally in Scriptaculous. Error caused by bridge code changes mentioned above ( http://jira.icesoft.org/browse/ICE-6705?focusedCommentId=42020&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_42020 ) still exists. (In 1.8 only. 3.2 seems fine.) Modified: C:\svn\ossrepo\icefaces\trunk\icefaces\bridge\lib\extras\autocomplete_ext.js Completed: At revision: 30751 Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\core\src\main\javascript\extras\extras.js Completed: At revision: 30755

Ken Fyten made changes - 10/Sep/12 10:05 AM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Ken Fyten made changes - 30/Nov/12 11:46 PM

Status	Resolved [ 5 ]	Closed [ 6 ]
Assignee Priority	P2 [ 10011 ]

People

Assignee:

yip.ng

Reporter:

Alessandro Rodi

Votes:

0 Vote for this issue

Watchers:

2 Start watching this issue

Dates

Created:

28/Mar/11 5:48 AM

Updated:

30/Nov/12 11:46 PM

Resolved:

10/Sep/12 10:05 AM