ICEfaces
  1. ICEfaces
  2. ICE-6669

The dateTimeEntry component needs to set proper tabindex in ARIA mode

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 2.0.1
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      *

      Description

      The dateTimeEntry component needs to be changed so that in ARIA mode it defaults to setting tabIndex=0 on the left-most input element (popup mode), or the currently selected date (non-popup mode), or the top-left arrow button if not date is specified. (Reported by Ken.)

        Issue Links

          Activity

          Hide
          yip.ng added a comment - - edited

          If user specifies tabindex, should take user's tabindex? May not be 0.

          Assume user won't set tabindex to < 0?

          Show
          yip.ng added a comment - - edited If user specifies tabindex, should take user's tabindex? May not be 0. Assume user won't set tabindex to < 0?
          Hide
          yip.ng added a comment - - edited

          Need to adjust keyboard shortcuts and focus management code as well.

          Show
          yip.ng added a comment - - edited Need to adjust keyboard shortcuts and focus management code as well.
          Hide
          yip.ng added a comment -

          Revision: 24185


          Modified : /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.datetimeentry/calendar.js
          Modified : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/datetimeentry/DateTimeEntryMeta.java
          Modified : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/datetimeentry/DateTimeEntryRenderer.java

          Show
          yip.ng added a comment - Revision: 24185 Modified : /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.datetimeentry/calendar.js Modified : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/datetimeentry/DateTimeEntryMeta.java Modified : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/datetimeentry/DateTimeEntryRenderer.java
          Hide
          Ken Fyten added a comment -

          An apparent regression from this change is that keyboard navigation (in default/ARIA mode) is no longer working at all with this component in the ace-showcase.

          Show
          Ken Fyten added a comment - An apparent regression from this change is that keyboard navigation (in default/ARIA mode) is no longer working at all with this component in the ace-showcase.
          Hide
          yip.ng added a comment - - edited

          Regression not caused by this change, but by changes from ICE-6490. (this pointers didn't get all changed. As a result one of the this pointers got lost.)

          Revision: 24209


          Modified : /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.datetimeentry/calendar.js

          Show
          yip.ng added a comment - - edited Regression not caused by this change, but by changes from ICE-6490 . (this pointers didn't get all changed. As a result one of the this pointers got lost.) Revision: 24209 Modified : /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.datetimeentry/calendar.js
          Hide
          yip.ng added a comment -

          From Ken:

          One thing I noticed during testing is that if you have the dateTimeEntry in popup mode, when you use open the popup by clicking the button, it should move focus to the current date in the popup automatically. Right now there is no way to navigate into the popup calendar using the keyboard at all.

          Show
          yip.ng added a comment - From Ken: One thing I noticed during testing is that if you have the dateTimeEntry in popup mode, when you use open the popup by clicking the button, it should move focus to the current date in the popup automatically. Right now there is no way to navigate into the popup calendar using the keyboard at all.
          Hide
          yip.ng added a comment - - edited

          You do have a way to navigate by keyboard. The popup is a YUI dialog. When the dialog is rendered, focus is set by the dialog to one of its buttons. You just have to back tab into the calendar cells from the buttons. Need to find out if we can overcome this dialog focusing behavior.

          Show
          yip.ng added a comment - - edited You do have a way to navigate by keyboard. The popup is a YUI dialog. When the dialog is rendered, focus is set by the dialog to one of its buttons. You just have to back tab into the calendar cells from the buttons. Need to find out if we can overcome this dialog focusing behavior.
          Hide
          yip.ng added a comment - - edited

          The focus management is getting more and more involved. There is focusing by the framework, focusing by YUI and focusing by the component.

          Show
          yip.ng added a comment - - edited The focus management is getting more and more involved. There is focusing by the framework, focusing by YUI and focusing by the component.
          Hide
          yip.ng added a comment -

          From Ken:

          So long as the focus is set somewhere on the dialog that's good enough for 2.0.1.

          Show
          yip.ng added a comment - From Ken: So long as the focus is set somewhere on the dialog that's good enough for 2.0.1.

            People

            • Assignee:
              yip.ng
              Reporter:
              yip.ng
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: