ICEfaces
  1. ICEfaces
  2. ICE-6661

Minify compat.js and icefaces-compat.js resources

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0.0
          • Fix Version/s: 2.0.1
          • Component/s: Bridge
          • Labels:
            None
          • Environment:
            server

            Description

            Minify compat.js and especially icefaces-compat.js resource to increase the resource loading efficiency.

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Mircea Toma added a comment -

              Modified build to minify compat.js and icefaces-compat.js resources.

              Show
              Mircea Toma added a comment - Modified build to minify compat.js and icefaces-compat.js resources.
              Hide
              Permalink
              Mircea Toma added a comment - - edited

              compat.js size went from 44kb down to 16kb.
              icefaces-compat.js went from 492kb down to 288kb.

              Show
              Mircea Toma added a comment - - edited compat.js size went from 44kb down to 16kb. icefaces-compat.js went from 492kb down to 288kb.
              Hide
              Permalink
              Ken Fyten added a comment -

              Looks like this commit is causing regressions with Compat component-showcase: See http://jira.icefaces.org/secure/attachment/12965/screenshot-01.png.

              Show
              Ken Fyten added a comment - Looks like this commit is causing regressions with Compat component-showcase: See http://jira.icefaces.org/secure/attachment/12965/screenshot-01.png .
              Hide
              Permalink
              Mircea Toma added a comment -

              Re-tested component-showcase with icefaces-compat.jar containing the minified JS resources but I could not reproduce the problem described above. The JS resources are loaded and evaluated without any issues.

              The problem described by http://jira.icefaces.org/secure/attachment/12965/screenshot-01.png is obviously caused by the failure to load compat.js and icefaces-compat.js resources. The cause of the problem must be on the server since the HTTP 404 errors are sent from there.

              Show
              Mircea Toma added a comment - Re-tested component-showcase with icefaces-compat.jar containing the minified JS resources but I could not reproduce the problem described above. The JS resources are loaded and evaluated without any issues. The problem described by http://jira.icefaces.org/secure/attachment/12965/screenshot-01.png is obviously caused by the failure to load compat.js and icefaces-compat.js resources. The cause of the problem must be on the server since the HTTP 404 errors are sent from there.
              Hide
              Permalink
              Mircea Toma added a comment -

              Added missing YUI compressor (v2.4.2) library into 'lib' directory. This way 'core' and 'compat' builds can use it to compress the JS resources.

              Show
              Mircea Toma added a comment - Added missing YUI compressor (v2.4.2) library into 'lib' directory. This way 'core' and 'compat' builds can use it to compress the JS resources.

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Mircea Toma
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: