Another tweak to the menu positioning logic. I'd suggest that you don't position the menu above the menubar unless it can fit completely in the available space.

Also, the top of the menu should always be under (or over) the menu-bar, not on top of it.

Case in screenshot 1 should not occur. It should always be like screenshot 2. This is yet another bug introduced by the optimizations done in ICE-4106. A value which should be calculated dynamically on the spot was "optimized" to be calculated only at the start of the function.

In screenshot 2, the menu is not wrongly positioned on top of the menu bar, it is to avoid the menu positioning beyond the top of the viewport. This is a requirement of ICE-3658. Do we want to revert that?

If the space above is larger than the space below, then better position menu above even if can't fit completely. Ohterwise if the menu bar is close to the bottom of the viewport user would complain again why we don't put the menu above.

For screenshot2 (overTop), the current behaviour is to position the submenu overtop of the root menu in order to maximize the amount of the submenu that can be made visible on the page, only in cases where there the sub-menu cannot be fully displayed either below or above the root-menu item. After review, this is judged to be a desirable feature, even if it means that in these cases the sub-menu may not appear in exactly the expected/usual location. It also offers benefits in mobile or limited-screen real-estate environments by ensuring the user will see and be able to use the sub-menu in virtually all cases. There is also precedent for this in desktop UI menu behaviour, where the specific position of a submenu is altered as required to ensure the entire sub-menu is visible on the screen.

Fixed bug that produced screenshot 1.

Revision: 24528

Modified : /icefaces/trunk/icefaces/bridge/component/menu.js

Tested successfully on icefaces1.8 trunk revision# 24720 using FF3.6, IE8 & chrome10.