ICEfaces
  1. ICEfaces
  2. ICE-6508

panelTabSet keyboard navigation not working when tabbed into

          Details

          • Assignee Priority:
            P1

            Description

            With addition of the tabindex attribute (ICE-5994) it is now possible to tab into the panelTabSet component. The keyboard navigation does not seem to work once the focus has been received. It does work once the tab has been selected via the mouse.

              Activity

              Ascending order - Click to sort in descending order
              Arran Mccullough created issue -
              Arran Mccullough made changes -
              Field Original Value New Value
              Salesforce Case [5007000000D5KoO]
              Arran Mccullough made changes -
              Attachment Case9380Example.war [ 12829 ]
              Ken Fyten made changes -
              Fix Version/s 1.8.2-EE-GA_P03 [ 10251 ]
              Ken Fyten made changes -
              Assignee Priority P2
              Assignee Adnan Durrani [ adnan.durrani ]
              Ken Fyten made changes -
              Assignee Priority P2 P1
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24576 Sun May 15 22:35:31 MDT 2011 adnan.durrani Fix for ICE-6508 (panelTabSet keyboard navigation not working when tabbed into)
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24577 Sun May 15 22:47:11 MDT 2011 adnan.durrani Fix for ICE-6508 (panelTabSet keyboard navigation not working when tabbed into)
              Files Changed
              Commit graph MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24578 Sun May 15 22:54:41 MDT 2011 adnan.durrani Fix for ICE-6508 (panelTabSet keyboard navigation not working when tabbed into)
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
              Adnan Durrani made changes -
              Status Open [ 1 ] In Progress [ 3 ]
              Hide
              Permalink
              Adnan Durrani added a comment -

              Command: Commit
              Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTabSetRenderer.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTabSetRenderer.java
              Completed: At revision: 24576

              Show
              Adnan Durrani added a comment - Command: Commit Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTabSetRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTabSetRenderer.java Completed: At revision: 24576
              Adnan Durrani made changes -
              Status In Progress [ 3 ] Resolved [ 5 ]
              Fix Version/s EE-2.0.0.GA_P01 [ 10271 ]
              Fix Version/s 2.1 [ 10241 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Adnan Durrani added a comment -

              Command: Commit
              Modified: D:\work\development\head\svn\ossrepo\icefaces2\branches\icefaces-2.0.x-maintenance\icefaces\compat\components\src\main\java\com\icesoft\faces\component\paneltabset\PanelTabSetRenderer.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces2\branches\icefaces-2.0.x-maintenance\icefaces\compat\components\src\main\java\com\icesoft\faces\component\paneltabset\PanelTabSetRenderer.java
              Completed: At revision: 24577

              Show
              Adnan Durrani added a comment - Command: Commit Modified: D:\work\development\head\svn\ossrepo\icefaces2\branches\icefaces-2.0.x-maintenance\icefaces\compat\components\src\main\java\com\icesoft\faces\component\paneltabset\PanelTabSetRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces2\branches\icefaces-2.0.x-maintenance\icefaces\compat\components\src\main\java\com\icesoft\faces\component\paneltabset\PanelTabSetRenderer.java Completed: At revision: 24577
              Hide
              Permalink
              Adnan Durrani added a comment -

              Command: Commit
              Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\paneltabset\PanelTabSetRenderer.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\paneltabset\PanelTabSetRenderer.java
              Completed: At revision: 24578

              Show
              Adnan Durrani added a comment - Command: Commit Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\paneltabset\PanelTabSetRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\paneltabset\PanelTabSetRenderer.java Completed: At revision: 24578
              Hide
              Permalink
              Mandeep Hayher added a comment -

              Tested on icefaces1.8 revision# 24720
              tabbing and keyboard navigation works fine on FF3.6, but user cannot tab back into input text fields from the panel tabset component by pressing shift+tab keys.

              On IE8 & Chrome10 the user cannot tab into the input text fields after the panel tabset component.

              Show
              Mandeep Hayher added a comment - Tested on icefaces1.8 revision# 24720 tabbing and keyboard navigation works fine on FF3.6, but user cannot tab back into input text fields from the panel tabset component by pressing shift+tab keys. On IE8 & Chrome10 the user cannot tab into the input text fields after the panel tabset component.
              Mandeep Hayher made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              Mandeep Hayher added a comment -

              Also on FF user can navigate only once through all components on the page, after tabbing through all components once, user can not tab into components above tabset.

              Show
              Mandeep Hayher added a comment - Also on FF user can navigate only once through all components on the page, after tabbing through all components once, user can not tab into components above tabset.
              Ken Fyten made changes -
              Assignee Adnan Durrani [ adnan.durrani ] yip.ng [ yip.ng ]
              Hide
              Permalink
              yip.ng added a comment - - edited

              Tabbing works fine in all 3 browsers once the fix for this JIRA is reverted, i.e. this fix for the keyboard navigation within the tabset (the addition of an onfocus listener to the tabs) wrecks the tabbing among the fields and components.

              Note that "after tabbing through all components once, user can not tab into components above tabset." is standard behavior, because in the test case only the group of fields around the tabset have tabindex. Many other fields are on the page that don't have tabindex. You have to cycle all through these before focus will get back to the test fields.

              Show
              yip.ng added a comment - - edited Tabbing works fine in all 3 browsers once the fix for this JIRA is reverted, i.e. this fix for the keyboard navigation within the tabset (the addition of an onfocus listener to the tabs) wrecks the tabbing among the fields and components. Note that "after tabbing through all components once, user can not tab into components above tabset." is standard behavior, because in the test case only the group of fields around the tabset have tabindex. Many other fields are on the page that don't have tabindex. You have to cycle all through these before focus will get back to the test fields.
              Hide
              Permalink
              Ken Fyten added a comment -

              So the only real failure here is this one:

              "On IE8 & Chrome10 the user cannot tab into the input text fields after the panel tabset component."

              We're going to need a version of this fix that also works with IE8 and Chrome.

              Show
              Ken Fyten added a comment - So the only real failure here is this one: "On IE8 & Chrome10 the user cannot tab into the input text fields after the panel tabset component." We're going to need a version of this fix that also works with IE8 and Chrome.
              Hide
              Permalink
              yip.ng added a comment -

              There is also the Shift-Tab not working in FF. Not the same as "tabbing into components above tabset" from the top.

              Show
              yip.ng added a comment - There is also the Shift-Tab not working in FF. Not the same as "tabbing into components above tabset" from the top.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24758 Thu Jun 02 14:52:43 MDT 2011 yip.ng ICE-6508: panelTabSet keyboard navigation not working when tabbed into.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24759 Thu Jun 02 14:57:01 MDT 2011 yip.ng ICE-6508: panelTabSet keyboard navigation not working when tabbed into.
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24760 Thu Jun 02 14:57:46 MDT 2011 yip.ng ICE-6508: panelTabSet keyboard navigation not working when tabbed into.
              Files Changed
              Commit graph MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
              Hide
              Permalink
              yip.ng added a comment -

              Fixed. Tested on FF, IE and Chrome. Note that the tab key is also used for intra-component navigation like the arrow keys. It was working like this before.

              Revision: 24758

              Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java

              Revision: 24759

              Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java

              Revision: 24760

              Modified : /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java

              Show
              yip.ng added a comment - Fixed. Tested on FF, IE and Chrome. Note that the tab key is also used for intra-component navigation like the arrow keys. It was working like this before. Revision: 24758 Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java Revision: 24759 Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java Revision: 24760 Modified : /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
              yip.ng made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Mandeep Hayher added a comment -

              Tested successfully on ICEfaces-1.8.2-GA_P03-bin (build6) using FF3.6, IE8 & Chrome11.

              Show
              Mandeep Hayher added a comment - Tested successfully on ICEfaces-1.8.2-GA_P03-bin (build6) using FF3.6, IE8 & Chrome11.
              Mandeep Hayher made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee yip.ng [ yip.ng ] Ken Fyten [ ken.fyten ]

                People

                • Assignee:
                  Ken Fyten
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: