Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.0.0
-
Fix Version/s: 2.0.0
-
Component/s: ACE-Components
-
Labels:None
-
Environment:jsf2.0, ICEfaces2.0, ACE
-
Affects:Compatibility/Configuration
Description
upon updating to yui3.20, it was noticed that the markup for sliderEntry shows the paths to images with escaping backslashes...
for example:-
"thumbUrl":"javax.faces.resource\/assets\/skins\/sam\/thumb-x.png.jsf?ln=yui\/3_2_0"
Problem is in JSONBUilder placing in the escaping and the images won't load now (with 3.2.0).
for example:-
"thumbUrl":"javax.faces.resource\/assets\/skins\/sam\/thumb-x.png.jsf?ln=yui\/3_2_0"
Problem is in JSONBUilder placing in the escaping and the images won't load now (with 3.2.0).
Activity
| Field | Original Value | New Value |
|---|---|---|
| Salesforce Case | [] | |
| Fix Version/s | 2.0.0 [ 10230 ] | |
| Affects | [Compatibility/Configuration] | |
| Assignee | Ken Fyten [ ken.fyten ] |
When carrying out a test related to ICE-6183, I noticed a YUI warning when loading the slider component. It said that the 'event-synthetic' library wasn't loaded (because we disabled dynamic loading). This library wasn't necessary in the previous version of YUI. Maybe this also has something to do with slider not displaying properly.
Show
Arturo Zambrano
added a comment - When carrying out a test related to ICE-6183 , I noticed a YUI warning when loading the slider component. It said that the 'event-synthetic' library wasn't loaded (because we disabled dynamic loading). This library wasn't necessary in the previous version of YUI. Maybe this also has something to do with slider not displaying properly.
| Salesforce Case | [] | |
| Assignee Priority | P1 | |
| Assignee | Ken Fyten [ ken.fyten ] | Yip Ng [ yip.ng ] |
| Salesforce Case | [] | |
| Assignee | Yip Ng [ yip.ng ] | Adnan Durrani [ adnan.durrani ] |
Judy also reporting that she is seeing "e.Event.define is not a function" --from event-focus-min.js.js.jsf?ln=yui/3_2_0, so the functions needed for slider seem to have changed.
| Salesforce Case | [] | |
| Description |
upon updating to yui3.20, it was noticed that the markup for sliderEntry shows the paths to images with escaping backslashes... for example:- "thumbUrl":"javax.faces.resource\/assets\/skins\/sam\/thumb-x.png.jsf?ln=yui\/3_2_0" Problem is in JSONBUilder placing in the escaping and the images won't load now (with 3.2.0). Since this property is not likely to change unless the skin or image has changed, then change to use the skinning/css to load the images. rather than using a param within the script to pass the image. link to show an example of the css classes to use is:- http://developer.yahoo.com/yui/3/examples/slider/slider_from_markup.html |
upon updating to yui3.20, it was noticed that the markup for sliderEntry shows the paths to images with escaping backslashes... for example:- "thumbUrl":"javax.faces.resource\/assets\/skins\/sam\/thumb-x.png.jsf?ln=yui\/3_2_0" Problem is in JSONBUilder placing in the escaping and the images won't load now (with 3.2.0). Since this property is not likely to change unless the skin or image has changed, then change to use the skinning/css to load the images. rather than using a param within the script to pass the image. link to show an example of the css classes to use is:- http://developer.yahoo.com/yui/3/examples/slider/slider_from_markup.html NOTE: The key requirement here is that we do not want to force the user to have to specify a thumb image as an attribute of the component. Instead, the skin CSS should specify the thumb image to use. |
I used Firebug's Net view to determine that the thumbnail image is not trying to be loaded, via any URL.
Show
Mark Collette
added a comment - I used Firebug's Net view to determine that the thumbnail image is not trying to be loaded, via any URL.
| Summary | modify sliderEntry so that images are loaded using css/skinning | sliderEntry not loading images / working since YUI 3.2.0 upgrade was completed |
| Salesforce Case | [] | |
| Description |
upon updating to yui3.20, it was noticed that the markup for sliderEntry shows the paths to images with escaping backslashes... for example:- "thumbUrl":"javax.faces.resource\/assets\/skins\/sam\/thumb-x.png.jsf?ln=yui\/3_2_0" Problem is in JSONBUilder placing in the escaping and the images won't load now (with 3.2.0). Since this property is not likely to change unless the skin or image has changed, then change to use the skinning/css to load the images. rather than using a param within the script to pass the image. link to show an example of the css classes to use is:- http://developer.yahoo.com/yui/3/examples/slider/slider_from_markup.html NOTE: The key requirement here is that we do not want to force the user to have to specify a thumb image as an attribute of the component. Instead, the skin CSS should specify the thumb image to use. |
upon updating to yui3.20, it was noticed that the markup for sliderEntry shows the paths to images with escaping backslashes... for example:- "thumbUrl":"javax.faces.resource\/assets\/skins\/sam\/thumb-x.png.jsf?ln=yui\/3_2_0" Problem is in JSONBUilder placing in the escaping and the images won't load now (with 3.2.0). |
| Assignee | Adnan Durrani [ adnan.durrani ] | Arturo Zambrano [ artzambrano ] |
Looks like the required libraries have changed.
Assigned to Art for priority resolution.
| Link | This issue blocks ICE-6273 [ ICE-6273 ] |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #23175 | Mon Nov 22 03:19:03 MST 2010 | art.zambrano | |
| Files Changed | ||||
MODIFY
/icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/sliderentry/SliderEntryMeta.java
|
The change hasn't resolved the issue completely, as the slider images are not appearing still.
| Salesforce Case | [] | |
| Assignee | Arturo Zambrano [ artzambrano ] | Yip Ng [ yip.ng ] |
| Attachment | screenshot-01.png [ 12690 ] |
From Ken:
Okay, slider, tabs, and dateTimeEntry are all working fine for me now after updating with Judy's change to adopt onDomready stuff.
Had to reload the page once in my browser to get the good images/styling
See screenshot 1.
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
| Assignee Priority | P1 |
I found the source of the escaped forward slashes, which is in JSONBuilder.entry(String,boolean). I commented out the forward slash escaping, which fixed the URL, but the image still wouldn't load.
public JSONBuilder entry(String key, String value, boolean isStringLiteral)
{ ... //value = value.replace("/", "\\/"); ... }return this;
}
It looks more like an issue with the change to YUI 3.2.0. We should investigate if YUI 3.2.0's slider allows for relative URLs, or if they need leading / or leading ./