ICEfaces
  1. ICEfaces
  2. ICE-6268

sliderEntry not loading images / working since YUI 3.2.0 upgrade was completed

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0.0
          • Fix Version/s: 2.0.0
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            jsf2.0, ICEfaces2.0, ACE
          • Affects:
            Compatibility/Configuration

            Description

            upon updating to yui3.20, it was noticed that the markup for sliderEntry shows the paths to images with escaping backslashes...
            for example:-
            "thumbUrl":"javax.faces.resource\/assets\/skins\/sam\/thumb-x.png.jsf?ln=yui\/3_2_0"

            Problem is in JSONBUilder placing in the escaping and the images won't load now (with 3.2.0).

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Mark Collette added a comment - - edited

              I found the source of the escaped forward slashes, which is in JSONBuilder.entry(String,boolean). I commented out the forward slash escaping, which fixed the URL, but the image still wouldn't load.

              public JSONBuilder entry(String key, String value, boolean isStringLiteral)

              { ... //value = value.replace("/", "\\/"); ... }

              return this;
              }

              It looks more like an issue with the change to YUI 3.2.0. We should investigate if YUI 3.2.0's slider allows for relative URLs, or if they need leading / or leading ./

              Show
              Mark Collette added a comment - - edited I found the source of the escaped forward slashes, which is in JSONBuilder.entry(String,boolean). I commented out the forward slash escaping, which fixed the URL, but the image still wouldn't load. public JSONBuilder entry(String key, String value, boolean isStringLiteral) { ... //value = value.replace("/", "\\/"); ... } return this; } It looks more like an issue with the change to YUI 3.2.0. We should investigate if YUI 3.2.0's slider allows for relative URLs, or if they need leading / or leading ./
              Hide
              Permalink
              Arturo Zambrano added a comment -

              When carrying out a test related to ICE-6183, I noticed a YUI warning when loading the slider component. It said that the 'event-synthetic' library wasn't loaded (because we disabled dynamic loading). This library wasn't necessary in the previous version of YUI. Maybe this also has something to do with slider not displaying properly.

              Show
              Arturo Zambrano added a comment - When carrying out a test related to ICE-6183 , I noticed a YUI warning when loading the slider component. It said that the 'event-synthetic' library wasn't loaded (because we disabled dynamic loading). This library wasn't necessary in the previous version of YUI. Maybe this also has something to do with slider not displaying properly.
              Hide
              Permalink
              Ken Fyten added a comment -

              Judy also reporting that she is seeing "e.Event.define is not a function" --from event-focus-min.js.js.jsf?ln=yui/3_2_0, so the functions needed for slider seem to have changed.

              Show
              Ken Fyten added a comment - Judy also reporting that she is seeing "e.Event.define is not a function" --from event-focus-min.js.js.jsf?ln=yui/3_2_0, so the functions needed for slider seem to have changed.
              Hide
              Permalink
              Mark Collette added a comment -

              I used Firebug's Net view to determine that the thumbnail image is not trying to be loaded, via any URL.

              Show
              Mark Collette added a comment - I used Firebug's Net view to determine that the thumbnail image is not trying to be loaded, via any URL.
              Hide
              Permalink
              Ken Fyten added a comment -

              Looks like the required libraries have changed.

              Assigned to Art for priority resolution.

              Show
              Ken Fyten added a comment - Looks like the required libraries have changed. Assigned to Art for priority resolution.
              Hide
              Permalink
              Ken Fyten added a comment -

              The change hasn't resolved the issue completely, as the slider images are not appearing still.

              Show
              Ken Fyten added a comment - The change hasn't resolved the issue completely, as the slider images are not appearing still.
              Hide
              Permalink
              yip.ng added a comment -

              From Ken:
              Okay, slider, tabs, and dateTimeEntry are all working fine for me now after updating with Judy's change to adopt onDomready stuff.
              Had to reload the page once in my browser to get the good images/styling

              See screenshot 1.

              Show
              yip.ng added a comment - From Ken: Okay, slider, tabs, and dateTimeEntry are all working fine for me now after updating with Judy's change to adopt onDomready stuff. Had to reload the page once in my browser to get the good images/styling See screenshot 1.

                People

                • Assignee:
                  yip.ng
                  Reporter:
                  Judy Guglielmin
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: