ICEfaces
  1. ICEfaces
  2. ICE-6242

ACE: Add min/max labels to sliderEntry component

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Beta2
          • Fix Version/s: 2.0.1
          • Component/s: ACE-Components, Sample Apps
          • Labels:
            None
          • Environment:
            IF 2 Advanced Comps.
          • Affects:
            Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial

            Description

            The sliderEntry component should support labels for the min. and max. of the range of values being entered.These labels should be optional to display and localizable by the application.

            Displaying additional labels for the values between min and max (the ends) would be a nice to have (for example, a value label for the middle of range as well).

              Activity

              Ascending order - Click to sort in descending order
              8 older comments
              Hide
              Permalink
              yip.ng added a comment -

              From Ken:

              This seem likely to be a problem with the slider component not respecting a dynamic change to the new showLabels attribute.

              Show
              yip.ng added a comment - From Ken: This seem likely to be a problem with the slider component not respecting a dynamic change to the new showLabels attribute.
              Hide
              Permalink
              yip.ng added a comment -

              Revision: 24218

              Modified : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/sliderentry/SliderEntryRenderer.java

              Show
              yip.ng added a comment - Revision: 24218 Modified : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/sliderentry/SliderEntryRenderer.java
              Hide
              Permalink
              Ken Fyten added a comment -

              I noticed that there are some styling/skinning issues that need tweaking.

              1. In the ace-showcase slider demo, the vertical slider with the "Rime" skin selected is not leaving enough horizontal whitespace between the slider bar and the labels. The Orange round slider button overlaps the label. Comparing the whitespace between the label and the bar on the vertical slider vs. the horizontal one seems to show that there is more space in the horizontal one. If so, making the vertical one use the same amount of whitespace should be sufficient. Otherwise, maybe scale the orange button images down a bit so they aren't so large ?

              2. In the ace-showcase slider demo, the vertical slider with the "Sam" skin selected has the Arrow slider button image pointing away from the labels. A quick reference check with the Swing slider shows that that labels and arrow should point to the right for a vertical slider. So the arrow image used in the Sam skin needs to be flipped horizontally to point to the right.

              Show
              Ken Fyten added a comment - I noticed that there are some styling/skinning issues that need tweaking. 1. In the ace-showcase slider demo, the vertical slider with the "Rime" skin selected is not leaving enough horizontal whitespace between the slider bar and the labels. The Orange round slider button overlaps the label. Comparing the whitespace between the label and the bar on the vertical slider vs. the horizontal one seems to show that there is more space in the horizontal one. If so, making the vertical one use the same amount of whitespace should be sufficient. Otherwise, maybe scale the orange button images down a bit so they aren't so large ? 2. In the ace-showcase slider demo, the vertical slider with the "Sam" skin selected has the Arrow slider button image pointing away from the labels. A quick reference check with the Swing slider shows that that labels and arrow should point to the right for a vertical slider. So the arrow image used in the Sam skin needs to be flipped horizontally to point to the right.
              Hide
              Permalink
              yip.ng added a comment -

              1. Done.

              Revision: 24251

              Modified : /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.sliderentry/slider.css

              Show
              yip.ng added a comment - 1. Done. Revision: 24251 Modified : /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.sliderentry/slider.css
              Hide
              Permalink
              yip.ng added a comment -

              2. Done.

              Revision: 24252

              Modified : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/sliderentry/skins/sam/thumb-y-shadow.png
              Modified : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/sliderentry/skins/sam/thumb-y.png

              Show
              yip.ng added a comment - 2. Done. Revision: 24252 Modified : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/sliderentry/skins/sam/thumb-y-shadow.png Modified : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/sliderentry/skins/sam/thumb-y.png

                People

                • Assignee:
                  yip.ng
                  Reporter:
                  Ken Fyten
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: