ICEfaces
  1. ICEfaces
  2. ICE-6215

Revamp ACE skinning resources build process

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-Beta2
    • Fix Version/s: 2.0.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      All
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.)

      Description

      Since we are using the concatenated CSS files to load a skin on a page, and it seems the most convenient way to do it (instead of loading each component's individual CSS file), it doesn't matter much where the individual CSS files are placed. Currently, these individual files are being generated and placed inside each component's resource library (e.g. for slider we are creating 'sam' and 'rime' directories inside 'resources/org.icefaces.component.sliderentry', and each of them contains the CSS file(s) for that component, for that skin).

      So, I thought that we could place all these generated individual files under the same (generated, not in the repository) resource library, maybe in 'org.icefaces.component.skins'. The advantage of this could be that it wouldn't be necessary to specify the resource library for each skin in the build script, potentially reducing the number of necessary lines to add a skin to just one (instead of 3). After all, all component-specific skin resources are now inside the component's source directory, so component developers only need to be concerned about that location, and the build script takes care of everything else, which is something that we wanted from the beginning.

      Also, it would be better to use the '/build' directory inside '/component' to place all the temporary files and staging directories of the skin resources build process, instead of '/tools/smartsprites'.

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23117 Sun Nov 14 19:06:16 MST 2010 art.zambrano ICE-6215 fixed issue with navigation arrows not appearing in calendar when not using sprites
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/datetimeentry/skins/sam/calendar.css
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23116 Sun Nov 14 18:48:28 MST 2010 art.zambrano ICE-6215 integrated the original, renamed sam skin CSS files into the new build mechanism; cleaned up and reorganized build.properties
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/menubutton/skins/sam/menu.css
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/tab/skins/sam/tabset.css
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/sliderentry/skins/sam/slider.css
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/build.properties
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/build.xml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23115 Sun Nov 14 16:16:18 MST 2010 art.zambrano ICE-6215 renamed 'resources' target to 'skins', and 'clean-resources' to 'clean-skins'
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/build.xml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23106 Fri Nov 12 05:11:38 MST 2010 art.zambrano ICE-6215 cleaned up and refactored skinning resources build process
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/build.xml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23078 Wed Nov 10 01:48:41 MST 2010 art.zambrano ICE-6215 baseline of new approach... it works, but needs some refactoring and clean up
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/build.xml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23051 Sun Nov 07 18:05:03 MST 2010 art.zambrano ICE-6215 moved the renamed sam skin files away from /resources and into /skins in /src/org/icefaces/component, following the same convention of placing skin-related files in a directory named 'skins', but in this case it can be used for common resources across components
        Files Changed
        Commit graph ADD /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/skins/sam_renamed/tabview-skin.css
        Commit graph ADD /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/skins
        Commit graph ADD /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/skins/sam_renamed/calendar-skin.css
        Commit graph ADD /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/skins/sam_renamed
        Commit graph DEL /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.skins
        Commit graph ADD /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/skins/sam_renamed/menu-skin.css
        Commit graph ADD /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/skins/sam_renamed/slider-skin.css
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/build.xml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23050 Sun Nov 07 17:16:08 MST 2010 art.zambrano ICE-6215 moved skin staging directories inside /component/build
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/build.properties
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/build.xml

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arturo Zambrano
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: