ICEfaces
  1. ICEfaces
  2. ICE-6215

Revamp ACE skinning resources build process

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-Beta2
    • Fix Version/s: 2.0.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      All
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.)

      Description

      Since we are using the concatenated CSS files to load a skin on a page, and it seems the most convenient way to do it (instead of loading each component's individual CSS file), it doesn't matter much where the individual CSS files are placed. Currently, these individual files are being generated and placed inside each component's resource library (e.g. for slider we are creating 'sam' and 'rime' directories inside 'resources/org.icefaces.component.sliderentry', and each of them contains the CSS file(s) for that component, for that skin).

      So, I thought that we could place all these generated individual files under the same (generated, not in the repository) resource library, maybe in 'org.icefaces.component.skins'. The advantage of this could be that it wouldn't be necessary to specify the resource library for each skin in the build script, potentially reducing the number of necessary lines to add a skin to just one (instead of 3). After all, all component-specific skin resources are now inside the component's source directory, so component developers only need to be concerned about that location, and the build script takes care of everything else, which is something that we wanted from the beginning.

      Also, it would be better to use the '/build' directory inside '/component' to place all the temporary files and staging directories of the skin resources build process, instead of '/tools/smartsprites'.

        Activity

        Arturo Zambrano created issue -
        Arturo Zambrano made changes -
        Field Original Value New Value
        Salesforce Case []
        Description Since we are using the concatenated CSS files to load a skin on a page, and it seems the most convenient way to do it (instead of loading each component's individual CSS file), it doesn't matter much where the individual CSS files are placed. Currently, these individual files are being generated and placed inside each component's resource library (e.g. for slider we are creating 'sam' and 'rime' directories inside 'resources/org.icefaces.component.sliderentry', and each of them contains the CSS file(s) for that component, for that skin).

        So, I thought that we could place all these generated individual files under the same (generated, not in the repository) resource library, maybe in 'org.icefaces.component.skins'. The advantage of this could be that it wouldn't be necessary to specify the resource library for each skin in the build script, potentially reducing the number of necessary lines to add a skin to just one (instead of 3). After all, all component-specific skin resources are now inside the component's source directory, so component developers only need to be concerned about that location, and the build script takes care of everything else, which is something that we wanted from the beginning.
        Since we are using the concatenated CSS files to load a skin on a page, and it seems the most convenient way to do it (instead of loading each component's individual CSS file), it doesn't matter much where the individual CSS files are placed. Currently, these individual files are being generated and placed inside each component's resource library (e.g. for slider we are creating 'sam' and 'rime' directories inside 'resources/org.icefaces.component.sliderentry', and each of them contains the CSS file(s) for that component, for that skin).

        So, I thought that we could place all these generated individual files under the same (generated, not in the repository) resource library, maybe in 'org.icefaces.component.skins'. The advantage of this could be that it wouldn't be necessary to specify the resource library for each skin in the build script, potentially reducing the number of necessary lines to add a skin to just one (instead of 3). After all, all component-specific skin resources are now inside the component's source directory, so component developers only need to be concerned about that location, and the build script takes care of everything else, which is something that we wanted from the beginning.

        Also, it would be better to use the '/build' directory inside '/component' to place all the temporary files and staging directories of the skin resources build process, instead of '/tools/smartsprites'.
        Arturo Zambrano made changes -
        Assignee Arturo Zambrano [ artzambrano ]
        Ken Fyten made changes -
        Salesforce Case []
        Fix Version/s 2.0.0 [ 10230 ]
        Affects [Documentation (User Guide, Ref. Guide, etc.)]
        Ken Fyten made changes -
        Assignee Priority P1
        Arturo Zambrano made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P1

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arturo Zambrano
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: