Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.0.0
-
Fix Version/s: 2.0.1
-
Component/s: ACE-Components
-
Labels:None
-
Environment:ACE, build
Description
Since MandatoryResourceComponent will be phased out as a way of determining all javascript dependencies, in favour of using the YUI 3 loader, we no longer will have a means of enumerating all javascript in use. So, we'll abandon the automatic pruning of icefaces-ace.jar's YUI files, and try an explicit strategy in the build.xml.
Issue Links
- is duplicated by
-
ICE-6249
ACE: Optimize build to only include those YUI libraries that are actually referenced by components included in the build.
-
- Closed
-
Activity
| Link | This issue depends on ICE-6195 [ ICE-6195 ] |
| Salesforce Case | [] | |
| Fix Version/s | 2.0.0 [ 10230 ] |
| Salesforce Case | [] | |
| Fix Version/s | 2.1 [ 10241 ] | |
| Fix Version/s | 2.0.0 [ 10230 ] |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #24009 | Thu Feb 24 19:52:24 MST 2011 | mark.collette | |
| Files Changed | ||||
MODIFY
/icefaces2/trunk/icefaces/ace/component/build.properties
MODIFY
/icefaces2/trunk/icefaces/ace/component/build.xml
|
| Salesforce Case | [] | |
| Fix Version/s | 2.0.1 [ 10255 ] | |
| Fix Version/s | 2.1 [ 10241 ] | |
| Assignee Priority | P1 | |
| Assignee | Mark Collette [ mark.collette ] |
| Salesforce Case | [] | |
| Affects Version/s | 2.0.0 [ 10230 ] | |
| Affects Version/s | 2.0-Beta2 [ 10242 ] |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #24075 | Wed Mar 02 12:36:58 MST 2011 | mark.collette | |
| Files Changed | ||||
|
MODIFY
/icefaces2/trunk/icefaces/ace/component/build.properties
|
Modified the build.properties to enable this by default.
Subversion 24075
Show
Mark Collette
added a comment - Modified the build.properties to enable this by default.
Subversion 24075
| Salesforce Case | [] | |
| Assignee Priority | P1 |
| Link | This issue depends on ICE-6195 [ ICE-6195 ] |
| Comment | [ Possibly not all our components will have @ManadatoryResourceComponent annotations, or that processing may be disabled, or others using the Advanced Component Environement for their own component might not use it. And since this is done at build time, possible it would make sense to scan the Base classes an the Renderer classes and the hand coded components to see their @ResourceDependency annotations, and build the list of all used javascript files from there. We'll have to see how the depended on jiras work out. ] |
| Salesforce Case | [] | |
| Description |
Once |
Since MandatoryResourceComponent will be phased out as a way of determining all javascript dependencies, in favour of using the YUI 3 loader, we no longer will have a means of enumerating all javascript in use. So, we'll abandon the automatic pruning of icefaces-ace.jar's YUI files, and try an explicit strategy in the build.xml. |
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Security | Private [ 10001 ] | |
| Resolution | Fixed [ 1 ] |
| Issue Type | New Feature [ 2 ] | Improvement [ 4 ] |
| Salesforce Case | [] |
| Link | This issue is duplicated by ICE-6633 [ ICE-6633 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
Since MandatoryResourceComponent will be phased out as a way of determining all javascript dependencies, in favour of using the YUI 3 loader, we no longer will have a means of enumerating all javascript in use. So, we'll abandon the automatic pruning of icefaces-ace.jar's YUI files, and try an explicit strategy in the build.xml.
Committed is a change that involves explicitly stating which parts of YUI 2 and 3 to include in the JAR. That is, it's a white list, not a black list. For now I've left the pruning turned off by default, in case I've missed anything from the white list. After testing, someone can turn it on by default. So do so, uncomment the exclude.unused.yui property in the ace/components/build.properties file.
Subversion 24009