ICEfaces
  1. ICEfaces
  2. ICE-6196

icefaces-ace.jar build only include used javascript files

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 2.0.1
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ACE, build

      Description

      Since MandatoryResourceComponent will be phased out as a way of determining all javascript dependencies, in favour of using the YUI 3 loader, we no longer will have a means of enumerating all javascript in use. So, we'll abandon the automatic pruning of icefaces-ace.jar's YUI files, and try an explicit strategy in the build.xml.

        Issue Links

          Activity

          Hide
          Mark Collette added a comment -

          Since MandatoryResourceComponent will be phased out as a way of determining all javascript dependencies, in favour of using the YUI 3 loader, we no longer will have a means of enumerating all javascript in use. So, we'll abandon the automatic pruning of icefaces-ace.jar's YUI files, and try an explicit strategy in the build.xml.

          Committed is a change that involves explicitly stating which parts of YUI 2 and 3 to include in the JAR. That is, it's a white list, not a black list. For now I've left the pruning turned off by default, in case I've missed anything from the white list. After testing, someone can turn it on by default. So do so, uncomment the exclude.unused.yui property in the ace/components/build.properties file.

          Subversion 24009

          Show
          Mark Collette added a comment - Since MandatoryResourceComponent will be phased out as a way of determining all javascript dependencies, in favour of using the YUI 3 loader, we no longer will have a means of enumerating all javascript in use. So, we'll abandon the automatic pruning of icefaces-ace.jar's YUI files, and try an explicit strategy in the build.xml. Committed is a change that involves explicitly stating which parts of YUI 2 and 3 to include in the JAR. That is, it's a white list, not a black list. For now I've left the pruning turned off by default, in case I've missed anything from the white list. After testing, someone can turn it on by default. So do so, uncomment the exclude.unused.yui property in the ace/components/build.properties file. Subversion 24009
          Hide
          Ken Fyten added a comment -

          Let's enable this by default now for 2.0.1.

          Show
          Ken Fyten added a comment - Let's enable this by default now for 2.0.1.
          Hide
          Mark Collette added a comment -

          Modified the build.properties to enable this by default.

          Subversion 24075

          Show
          Mark Collette added a comment - Modified the build.properties to enable this by default. Subversion 24075

            People

            • Assignee:
              Mark Collette
              Reporter:
              Mark Collette
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: