ICEfaces
  1. ICEfaces
  2. ICE-6183

ACE component making request to external site

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-Beta2
    • Fix Version/s: 2.0.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ACE

      Description

      Running the ACE showcase application, you can see during the initial page load that a request is being made to the Yahoo's external API site:

      http://yui.yahooapis.com/combo?3.1.1/build/oop/oop-min.js&3.1.1/build/event-custom/event-custom-min.js&3.1.1/build/attribute/attribute-base-min.js&3.1.1/build/base/base-base-min.js&3.1.1/build/event/event-base-min.js&3.1.1/build/dom/dom-min.js&3.1.1/build/node/node-min.js&3.1.1/build/event/event-delegate-min.js

      This won't be acceptable for most intranet type deployments and could also constitute a security risk.

        Issue Links

          Activity

          Deryk Sinotte created issue -
          Deryk Sinotte made changes -
          Field Original Value New Value
          Salesforce Case []
          Fix Version/s 2.0.0 [ 10230 ]
          Assignee Ken Fyten [ ken.fyten ]
          Ken Fyten made changes -
          Salesforce Case []
          Component/s ACE-Components [ 10050 ]
          Assignee Priority P1
          Assignee Ken Fyten [ ken.fyten ] Arturo Zambrano [ artzambrano ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #22987 Mon Nov 01 03:51:28 MDT 2010 art.zambrano ICE-6183 Fixed by adding necessary @ResourceDependency's and adding 'bootstrap: false' flag to YUI() function in component.js
          Files Changed
          Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.util/component.js
          Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/datetimeentry/DateTimeEntryMeta.java
          Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/animation/AnimationBehavior.java
          Hide
          Arturo Zambrano added a comment -

          Fixed by finally adding the 'bootstrap: false' flag to the YUI() function in component.js and by adding the required @ResourceDepenency's to AnimationBahavior and DateTimeEntry. The required resources were needed by anim-min.js, so they have to be loaded BEFORE loading anim-min.js.

          Show
          Arturo Zambrano added a comment - Fixed by finally adding the 'bootstrap: false' flag to the YUI() function in component.js and by adding the required @ResourceDepenency's to AnimationBahavior and DateTimeEntry. The required resources were needed by anim-min.js, so they have to be loaded BEFORE loading anim-min.js.
          Hide
          Mark Collette added a comment -

          #2 and #3 should take into account ICE-6194. #1 can be finished on it's own, but #2 and #3 should be coordinated with, or be done after, ICE-6194.

          Show
          Mark Collette added a comment - #2 and #3 should take into account ICE-6194 . #1 can be finished on it's own, but #2 and #3 should be coordinated with, or be done after, ICE-6194 .
          Mark Collette made changes -
          Link This issue depends on ICE-6194 [ ICE-6194 ]
          Mark Collette made changes -
          Link This issue blocks ICE-6196 [ ICE-6196 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #23018 Wed Nov 03 03:42:03 MDT 2010 art.zambrano ICE-6183 fixed the rest of the missing resources
          Files Changed
          Commit graph ADD /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/linkbutton/skins/sam/menu-button-arrow-disabled.png
          Commit graph ADD /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/linkbutton/skins/sam/split-button-arrow-hover.png
          Commit graph ADD /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/linkbutton/skins/sam/split-button-arrow-focus.png
          Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/linkbutton/skins/sam/linkbutton.css
          Commit graph ADD /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/linkbutton/skins/sam/split-button-arrow-active.png
          Commit graph ADD /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/linkbutton/skins/sam/split-button-arrow.png
          Commit graph ADD /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/linkbutton/skins/sam/split-button-arrow-disabled.png
          Commit graph ADD /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/linkbutton/skins/sam/menu-button-arrow.png
          Hide
          Mark Collette added a comment -

          Basically, what remains, is to test this both with MandatoryResourceComponent enabled and disabled.

          Show
          Mark Collette added a comment - Basically, what remains, is to test this both with MandatoryResourceComponent enabled and disabled.
          Hide
          Arturo Zambrano added a comment -

          I tested the following pages with @MandatoryResourceComponent enabled and disabled (commented out from all renderer classes).

          1 http://localhost:8080/ace-showcase/main.jsf
          2 http://localhost:8080/ace-showcase/dateTimeEntry.jsf
          3 http://localhost:8080/ace-showcase/tabSetServer.jsf
          4 http://localhost:8080/ace-showcase/pushButton.jsf
          5 http://localhost:8080/ace-test/calendar.jsf
          6 http://localhost:8080/ace-test/slider.jsf
          7 http://localhost:8080/ace-test/buttons/checkboxSam.jsf
          8 http://localhost:8080/ace-test/buttons/menubutton.jsf

          I confirmed, by comparing the source code of both versions, the difference in the number of resources loaded (with @MandatoryResourceComponent there are more resources in the page). In both cases, the pages worked normally, there were no warnings in the console (except for slider, but because of another issue).

          So, it's safe to say that the 'bootstrap: false' flag does not affect the @MandatoryResourceComponent functionality.

          Show
          Arturo Zambrano added a comment - I tested the following pages with @MandatoryResourceComponent enabled and disabled (commented out from all renderer classes). 1 http://localhost:8080/ace-showcase/main.jsf 2 http://localhost:8080/ace-showcase/dateTimeEntry.jsf 3 http://localhost:8080/ace-showcase/tabSetServer.jsf 4 http://localhost:8080/ace-showcase/pushButton.jsf 5 http://localhost:8080/ace-test/calendar.jsf 6 http://localhost:8080/ace-test/slider.jsf 7 http://localhost:8080/ace-test/buttons/checkboxSam.jsf 8 http://localhost:8080/ace-test/buttons/menubutton.jsf I confirmed, by comparing the source code of both versions, the difference in the number of resources loaded (with @MandatoryResourceComponent there are more resources in the page). In both cases, the pages worked normally, there were no warnings in the console (except for slider, but because of another issue). So, it's safe to say that the 'bootstrap: false' flag does not affect the @MandatoryResourceComponent functionality.
          Arturo Zambrano made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Assignee Priority P1
          Ken Fyten made changes -
          Link This issue blocks ICE-6633 [ ICE-6633 ]
          Ken Fyten made changes -
          Link This issue blocks ICE-6196 [ ICE-6196 ]

            People

            • Assignee:
              Arturo Zambrano
              Reporter:
              Deryk Sinotte
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: