ICEfaces
  1. ICEfaces
  2. ICE-6138

panelTabSet style issue in Chrome and Safari

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Won't Fix
          • Affects Version/s: 2.0-Beta1
          • Fix Version/s: 2.0.0
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            Chrome and Safari browsers
          • ICEsoft Forum Reference:
          • Affects:
            Compatibility/Configuration
          • Workaround Exists:
            Yes
          • Workaround Description:
            Hide
            Adjust the view attribute so that all browsers get consistent markup:

            <f:view contentType="text/html">
            Show
            Adjust the view attribute so that all browsers get consistent markup: <f:view contentType="text/html">

            Description

            The panelTabSet displays with large spaces above and below the tab labels. This issue is not seen with Firefox or IE. The issue can be reproduced in FF and IE by using the following DOCTYPE:

            <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "DTD/xhtml1-strict.dtd">

            But changing to this DOCTYPE makes it work in FF/IE but not in Chrome/Safari:

            <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
            1. File
              first.xhtml
              1 kB
              Arran Mccullough
            1. tab-style-issue-chrome.JPG
              45 kB
            2. tab-style-issue-firefox.JPG
              79 kB
            3. tab-style-issue-safari.JPG
              56 kB

              Issue Links

              blocks

              Bug - A problem which impairs or prevents the functions of the product. ICE-5936 menuBar/menuItem does not expand/expand again

              • Major - Major loss of function.
              • Closed
              is duplicated by

              Bug - A problem which impairs or prevents the functions of the product. ICE-6229 Menubar doesn't work in Chrome

              • Major - Major loss of function.
              • Closed

              Bug - A problem which impairs or prevents the functions of the product. ICE-6230 selectInputDate popup not working

              • Major - Major loss of function.
              • Closed

                Activity

                Descending order - Click to sort in ascending order
                Hide
                Permalink
                Deryk Sinotte added a comment -

                In order to get WebKit based browsers to receive markup consistent with other browser, you specify the content type in the view tag:

                <f:view contentType="text/html">

                Show
                Deryk Sinotte added a comment - In order to get WebKit based browsers to receive markup consistent with other browser, you specify the content type in the view tag: <f:view contentType="text/html">
                Hide
                Permalink
                Ken Fyten added a comment -

                Up to Alpha 3 release, the ICEfaces response writer (DOMResponseWriter) was returned hardcoded values for:

                content type: text/html
                encoding: UTF-8

                While this covers a wide range of use cases, it's not adaptable to change by application developers. Changes to the DOMResponseWriter in ICE-5664 - to provide better support for determining the proper content type and encoding - makes for a more compatible ICEfaces experience.

                However, now that the values are no longer hard coded, browsers can potentially handle the markup differently based on what they accept and prefer. For example Chrome and Safari currently prefer "application/xhtml+xml" over "text/html":

                Accept: application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,/;q=0.5

                whereas Firefox prefers "text/html"

                Accept: text/html,application/xhtml+xml,application/xml;q=0.9,/;q=0.8

                This is all fine (and better explained here - http://www​.w3.org/TR​/xhtml-med​ia-types/)except that if the content type "application/xhtml-xml" is returned, then the default namespace must also be included or the page will not render correctly:

                <html xmlns="http://www.w3.org/1999/xhtml">

                Show
                Ken Fyten added a comment - Up to Alpha 3 release, the ICEfaces response writer (DOMResponseWriter) was returned hardcoded values for: content type: text/html encoding: UTF-8 While this covers a wide range of use cases, it's not adaptable to change by application developers. Changes to the DOMResponseWriter in ICE-5664 - to provide better support for determining the proper content type and encoding - makes for a more compatible ICEfaces experience. However, now that the values are no longer hard coded, browsers can potentially handle the markup differently based on what they accept and prefer. For example Chrome and Safari currently prefer "application/xhtml+xml" over "text/html": Accept: application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png, / ;q=0.5 whereas Firefox prefers "text/html" Accept: text/html,application/xhtml+xml,application/xml;q=0.9, / ;q=0.8 This is all fine (and better explained here - http://www ​.w3.org/TR​/xhtml-med​ia-types/)except that if the content type "application/xhtml-xml" is returned, then the default namespace must also be included or the page will not render correctly: <html xmlns="http://www.w3.org/1999/xhtml">
                Hide
                Permalink
                Nicklas Karlsson added a comment -

                The issue is (at least for Chome) related to pages that are ui:included. Looks ok on plain page but breaks up when the tab uses ui:insert to include panelTab content.

                Show
                Nicklas Karlsson added a comment - The issue is (at least for Chome) related to pages that are ui:included. Looks ok on plain page but breaks up when the tab uses ui:insert to include panelTab content.
                Hide
                Permalink
                Ken Fyten added a comment -

                Please retest with latest icefaces2/trunk.

                Show
                Ken Fyten added a comment - Please retest with latest icefaces2/trunk.

                  People

                  • Assignee:
                    Ken Fyten
                    Reporter:
                    Arran Mccullough
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: