ICEfaces
  1. ICEfaces
  2. ICE-6138

panelTabSet style issue in Chrome and Safari

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 2.0-Beta1
    • Fix Version/s: 2.0.0
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      Chrome and Safari browsers
    • Affects:
      Compatibility/Configuration
    • Workaround Exists:
      Yes
    • Workaround Description:
      Hide
      Adjust the view attribute so that all browsers get consistent markup:

      <f:view contentType="text/html">
      Show
      Adjust the view attribute so that all browsers get consistent markup: <f:view contentType="text/html">

      Description

      The panelTabSet displays with large spaces above and below the tab labels. This issue is not seen with Firefox or IE. The issue can be reproduced in FF and IE by using the following DOCTYPE:

      <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "DTD/xhtml1-strict.dtd">

      But changing to this DOCTYPE makes it work in FF/IE but not in Chrome/Safari:

      <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
      1. first.xhtml
        1 kB
        Arran Mccullough
      1. tab-style-issue-chrome.JPG
        45 kB
      2. tab-style-issue-firefox.JPG
        79 kB
      3. tab-style-issue-safari.JPG
        56 kB

        Issue Links

          Activity

          Arran Mccullough created issue -
          Arran Mccullough made changes -
          Field Original Value New Value
          Attachment tab-style-issue-chrome.JPG [ 12621 ]
          Attachment tab-style-issue-firefox.JPG [ 12622 ]
          Attachment tab-style-issue-safari.JPG [ 12623 ]
          Arran Mccullough made changes -
          Attachment first.xhtml [ 12624 ]
          Arran Mccullough made changes -
          Salesforce Case [5007000000DZozu]
          Ken Fyten made changes -
          Fix Version/s 2.0.0 [ 10230 ]
          Ken Fyten made changes -
          Assignee Priority P2
          Assignee Yip Ng [ yip.ng ]
          Hide
          Ken Fyten added a comment -

          Please retest with latest icefaces2/trunk.

          Show
          Ken Fyten added a comment - Please retest with latest icefaces2/trunk.
          Ken Fyten made changes -
          Assignee Yip Ng [ yip.ng ] Arran Mccullough [ arran.mccullough ]
          Hide
          Nicklas Karlsson added a comment -

          The issue is (at least for Chome) related to pages that are ui:included. Looks ok on plain page but breaks up when the tab uses ui:insert to include panelTab content.

          Show
          Nicklas Karlsson added a comment - The issue is (at least for Chome) related to pages that are ui:included. Looks ok on plain page but breaks up when the tab uses ui:insert to include panelTab content.
          Ken Fyten made changes -
          Assignee Arran Mccullough [ arran.mccullough ] Mark Collette [ mark.collette ]
          Arran Mccullough made changes -
          Salesforce Case [5007000000DZozu] [5007000000DZozu, 5007000000ETY0G]
          Ken Fyten made changes -
          Assignee Priority P2
          Ken Fyten made changes -
          Assignee Mark Collette [ mark.collette ] Ken Fyten [ ken.fyten ]
          Ken Fyten made changes -
          Hide
          Ken Fyten added a comment -

          Up to Alpha 3 release, the ICEfaces response writer (DOMResponseWriter) was returned hardcoded values for:

          content type: text/html
          encoding: UTF-8

          While this covers a wide range of use cases, it's not adaptable to change by application developers. Changes to the DOMResponseWriter in ICE-5664 - to provide better support for determining the proper content type and encoding - makes for a more compatible ICEfaces experience.

          However, now that the values are no longer hard coded, browsers can potentially handle the markup differently based on what they accept and prefer. For example Chrome and Safari currently prefer "application/xhtml+xml" over "text/html":

          Accept: application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,/;q=0.5

          whereas Firefox prefers "text/html"

          Accept: text/html,application/xhtml+xml,application/xml;q=0.9,/;q=0.8

          This is all fine (and better explained here - http://www​.w3.org/TR​/xhtml-med​ia-types/)except that if the content type "application/xhtml-xml" is returned, then the default namespace must also be included or the page will not render correctly:

          <html xmlns="http://www.w3.org/1999/xhtml">

          Show
          Ken Fyten added a comment - Up to Alpha 3 release, the ICEfaces response writer (DOMResponseWriter) was returned hardcoded values for: content type: text/html encoding: UTF-8 While this covers a wide range of use cases, it's not adaptable to change by application developers. Changes to the DOMResponseWriter in ICE-5664 - to provide better support for determining the proper content type and encoding - makes for a more compatible ICEfaces experience. However, now that the values are no longer hard coded, browsers can potentially handle the markup differently based on what they accept and prefer. For example Chrome and Safari currently prefer "application/xhtml+xml" over "text/html": Accept: application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png, / ;q=0.5 whereas Firefox prefers "text/html" Accept: text/html,application/xhtml+xml,application/xml;q=0.9, / ;q=0.8 This is all fine (and better explained here - http://www ​.w3.org/TR​/xhtml-med​ia-types/)except that if the content type "application/xhtml-xml" is returned, then the default namespace must also be included or the page will not render correctly: <html xmlns="http://www.w3.org/1999/xhtml">
          Ken Fyten made changes -
          Workaround Description Adding the following to each page snippet that is being ui:included should resolve the issue:

          <html xmlns="http://www.w3.org/1999/xhtml">
          Workaround Exists [Yes]
          Affects [Compatibility/Configuration]
          Deryk Sinotte made changes -
          Workaround Description Adding the following to each page snippet that is being ui:included should resolve the issue:

          <html xmlns="http://www.w3.org/1999/xhtml">
          Adjust the view attribute so that all browsers get consistent markup:

          <f:view contentType="text/html">
          Hide
          Deryk Sinotte added a comment -

          In order to get WebKit based browsers to receive markup consistent with other browser, you specify the content type in the view tag:

          <f:view contentType="text/html">

          Show
          Deryk Sinotte added a comment - In order to get WebKit based browsers to receive markup consistent with other browser, you specify the content type in the view tag: <f:view contentType="text/html">
          Ken Fyten made changes -
          Link This issue is duplicated by ICE-6229 [ ICE-6229 ]
          Ken Fyten made changes -
          Link This issue is duplicated by ICE-6230 [ ICE-6230 ]
          Ken Fyten made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Won't Fix [ 2 ]
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Christian Wilhelm made changes -
          Link This issue blocks ICE-5936 [ ICE-5936 ]

            People

            • Assignee:
              Ken Fyten
              Reporter:
              Arran Mccullough
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: