ICEfaces
  1. ICEfaces
  2. ICE-6039

Prototype multiple loading causes element decoration failures

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Beta1
          • Fix Version/s: 2.0-Beta2, 2.0.0
          • Component/s: Bridge
          • Labels:
            None
          • Environment:
            IE6/7

            Description

            When Prototype library is loaded or evaluated multiple times within the same window the element decoration done by Prototype to extend element's functionality fails.

              Activity

              Ascending order - Click to sort in descending order
              Mircea Toma created issue -
              Mircea Toma made changes -
              Field Original Value New Value
              Assignee Mircea Toma [ mircea.toma ]
              Mircea Toma made changes -
              Salesforce Case []
              Fix Version/s 2.0-Beta2 [ 10242 ]
              Hide
              Permalink
              Mircea Toma added a comment -

              Attach patch that fixes Prototype multiple reload confusion.

              Show
              Mircea Toma added a comment - Attach patch that fixes Prototype multiple reload confusion.
              Mircea Toma made changes -
              Attachment prototype-reload.patch [ 12552 ]
              Ken Fyten made changes -
              Salesforce Case []
              Assignee Priority P1
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #22348 Wed Sep 15 07:42:37 MDT 2010 mircea.toma ICE-6039 Make sure the detection of browser features is done only once when Prototype code is evaluated multiple times.
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/javascript/prototype/prototype.js
              Hide
              Permalink
              Mircea Toma added a comment -

              Prototype chooses an IE specific strategy of decorating element when window.HTMLElement object is missing. Once IE decoration is chosen it creates window.HTMLElement object. When Prototype library is loaded or evaluated the second time it will detect the window.HTMLElement object and choose a different decoration strategy.
              Changed Prototype so that the detection of browser features is done only once (during the first load) when Prototype code is evaluated multiple times.

              Show
              Mircea Toma added a comment - Prototype chooses an IE specific strategy of decorating element when window.HTMLElement object is missing. Once IE decoration is chosen it creates window.HTMLElement object. When Prototype library is loaded or evaluated the second time it will detect the window.HTMLElement object and choose a different decoration strategy. Changed Prototype so that the detection of browser features is done only once (during the first load) when Prototype code is evaluated multiple times.
              Mircea Toma made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 2.0.0 [ 10230 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Priority P1
              Hide
              Permalink
              Jochen Klein added a comment -

              The way the BrowserFeatures are attached to the window will overwrite any already loaded version of Prototype.
              I am testing in a portal environment and the portal loads Prototype already. icsfaces-compat overwrites window.Prototype now!

              Show
              Jochen Klein added a comment - The way the BrowserFeatures are attached to the window will overwrite any already loaded version of Prototype. I am testing in a portal environment and the portal loads Prototype already. icsfaces-compat overwrites window.Prototype now!
              Hide
              Permalink
              Mircea Toma added a comment -

              Joachen, you're right. The fix for Prototype overwriting was committed under http://jira.icefaces.org/browse/IPCK-236 . See ?focusedCommentId=33094&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_33094 .

              Show
              Mircea Toma added a comment - Joachen, you're right. The fix for Prototype overwriting was committed under http://jira.icefaces.org/browse/IPCK-236 . See ?focusedCommentId=33094&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_33094 .

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Mircea Toma
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: