ICEfaces
  1. ICEfaces
  2. ICE-6039

Prototype multiple loading causes element decoration failures

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-Beta1
    • Fix Version/s: 2.0-Beta2, 2.0.0
    • Component/s: Bridge
    • Labels:
      None
    • Environment:
      IE6/7

      Description

      When Prototype library is loaded or evaluated multiple times within the same window the element decoration done by Prototype to extend element's functionality fails.

        Activity

        Hide
        Mircea Toma added a comment -

        Attach patch that fixes Prototype multiple reload confusion.

        Show
        Mircea Toma added a comment - Attach patch that fixes Prototype multiple reload confusion.
        Hide
        Mircea Toma added a comment -

        Prototype chooses an IE specific strategy of decorating element when window.HTMLElement object is missing. Once IE decoration is chosen it creates window.HTMLElement object. When Prototype library is loaded or evaluated the second time it will detect the window.HTMLElement object and choose a different decoration strategy.
        Changed Prototype so that the detection of browser features is done only once (during the first load) when Prototype code is evaluated multiple times.

        Show
        Mircea Toma added a comment - Prototype chooses an IE specific strategy of decorating element when window.HTMLElement object is missing. Once IE decoration is chosen it creates window.HTMLElement object. When Prototype library is loaded or evaluated the second time it will detect the window.HTMLElement object and choose a different decoration strategy. Changed Prototype so that the detection of browser features is done only once (during the first load) when Prototype code is evaluated multiple times.
        Hide
        Jochen Klein added a comment -

        The way the BrowserFeatures are attached to the window will overwrite any already loaded version of Prototype.
        I am testing in a portal environment and the portal loads Prototype already. icsfaces-compat overwrites window.Prototype now!

        Show
        Jochen Klein added a comment - The way the BrowserFeatures are attached to the window will overwrite any already loaded version of Prototype. I am testing in a portal environment and the portal loads Prototype already. icsfaces-compat overwrites window.Prototype now!
        Hide
        Mircea Toma added a comment -

        Joachen, you're right. The fix for Prototype overwriting was committed under http://jira.icefaces.org/browse/IPCK-236 . See ?focusedCommentId=33094&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_33094 .

        Show
        Mircea Toma added a comment - Joachen, you're right. The fix for Prototype overwriting was committed under http://jira.icefaces.org/browse/IPCK-236 . See ?focusedCommentId=33094&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_33094 .

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Mircea Toma
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: