ICEfaces
  1. ICEfaces
  2. ICE-5999

Static panelTabSet non-selected tab label facet not decoding

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.2-EE-GA_P01
    • Fix Version/s: 2.0-Beta2, 2.0.0
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      All

      Description

      When building a dynamic panelTabSet using a c:forEach component, including a commandButton/Link in the panelTab label, the action event is not called for tabs that are not currently selected.

        Activity

        Hide
        Mark Collette added a comment -

        Investigated issue where the panelTabSet was used in two different configurations, and in one, an ice:commandLink in the label facet of a non-selected panelTab could be clicked, and have its action method called, and in the other configuration the action method would not be called. The scenario that worked was when using the value property of the panelTabSet, to create a dynamic list of panelTabs, using the panelTabSet's UIData mechanism. The scenario that did not work was using a c:forEach to create a dynamic list of panelTabs, but that used the panelTabSet's static mechanism.

        Investigated differences in the generated markup, but didn't find anything inexplicably different. Investigated the javascript POST, and determined that server calls were happening in both cases. Investigated the lifecycle of the commandLink, and determined that it was not receiving phases. Auditing of the panelTabSet code indicated that there were two distinct code paths for passing phases to children, which would affect non-selected tab label facets. Normalised the code on the technique that is correct in all cases.

        icefaces 1.8.x trunk
        Subversion 22190

        icefaces 2 trunk
        Subversion 22189

        Show
        Mark Collette added a comment - Investigated issue where the panelTabSet was used in two different configurations, and in one, an ice:commandLink in the label facet of a non-selected panelTab could be clicked, and have its action method called, and in the other configuration the action method would not be called. The scenario that worked was when using the value property of the panelTabSet, to create a dynamic list of panelTabs, using the panelTabSet's UIData mechanism. The scenario that did not work was using a c:forEach to create a dynamic list of panelTabs, but that used the panelTabSet's static mechanism. Investigated differences in the generated markup, but didn't find anything inexplicably different. Investigated the javascript POST, and determined that server calls were happening in both cases. Investigated the lifecycle of the commandLink, and determined that it was not receiving phases. Auditing of the panelTabSet code indicated that there were two distinct code paths for passing phases to children, which would affect non-selected tab label facets. Normalised the code on the technique that is correct in all cases. icefaces 1.8.x trunk Subversion 22190 icefaces 2 trunk Subversion 22189
        Hide
        Mark Collette added a comment -

        Deryk pointed out that I had accidentally committed the wrong file to icefaces 2, for this fix. Turns out that I had committed a test file, for reproducing the issue, and not even committed the actual code fix. First commit here is to roll back the damage, and the second commit is the actual fix.

        icefaces 2 trunk
        Subversion 22214
        Subversion 22215

        Show
        Mark Collette added a comment - Deryk pointed out that I had accidentally committed the wrong file to icefaces 2, for this fix. Turns out that I had committed a test file, for reproducing the issue, and not even committed the actual code fix. First commit here is to roll back the damage, and the second commit is the actual fix. icefaces 2 trunk Subversion 22214 Subversion 22215

          People

          • Assignee:
            Mark Collette
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: