ICEfaces
  1. ICEfaces
  2. ICE-5999

Static panelTabSet non-selected tab label facet not decoding

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.2-EE-GA_P01
    • Fix Version/s: 2.0-Beta2, 2.0.0
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      All

      Description

      When building a dynamic panelTabSet using a c:forEach component, including a commandButton/Link in the panelTab label, the action event is not called for tabs that are not currently selected.

        Activity

        Arran Mccullough created issue -
        Arran Mccullough made changes -
        Field Original Value New Value
        Salesforce Case [5007000000C5PA1]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22189 Tue Aug 17 17:53:55 MDT 2010 mark.collette ICE-5999 : Static panelTabSet non-selected tab label facet not decoding
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/samples/component-showcase/web/WEB-INF/includes/examples/panel/panelTabSet-dynamic.xhtml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22190 Tue Aug 17 18:53:13 MDT 2010 mark.collette ICE-5999 : Static panelTabSet non-selected tab label facet not decoding
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSet.java
        Hide
        Mark Collette added a comment -

        Investigated issue where the panelTabSet was used in two different configurations, and in one, an ice:commandLink in the label facet of a non-selected panelTab could be clicked, and have its action method called, and in the other configuration the action method would not be called. The scenario that worked was when using the value property of the panelTabSet, to create a dynamic list of panelTabs, using the panelTabSet's UIData mechanism. The scenario that did not work was using a c:forEach to create a dynamic list of panelTabs, but that used the panelTabSet's static mechanism.

        Investigated differences in the generated markup, but didn't find anything inexplicably different. Investigated the javascript POST, and determined that server calls were happening in both cases. Investigated the lifecycle of the commandLink, and determined that it was not receiving phases. Auditing of the panelTabSet code indicated that there were two distinct code paths for passing phases to children, which would affect non-selected tab label facets. Normalised the code on the technique that is correct in all cases.

        icefaces 1.8.x trunk
        Subversion 22190

        icefaces 2 trunk
        Subversion 22189

        Show
        Mark Collette added a comment - Investigated issue where the panelTabSet was used in two different configurations, and in one, an ice:commandLink in the label facet of a non-selected panelTab could be clicked, and have its action method called, and in the other configuration the action method would not be called. The scenario that worked was when using the value property of the panelTabSet, to create a dynamic list of panelTabs, using the panelTabSet's UIData mechanism. The scenario that did not work was using a c:forEach to create a dynamic list of panelTabs, but that used the panelTabSet's static mechanism. Investigated differences in the generated markup, but didn't find anything inexplicably different. Investigated the javascript POST, and determined that server calls were happening in both cases. Investigated the lifecycle of the commandLink, and determined that it was not receiving phases. Auditing of the panelTabSet code indicated that there were two distinct code paths for passing phases to children, which would affect non-selected tab label facets. Normalised the code on the technique that is correct in all cases. icefaces 1.8.x trunk Subversion 22190 icefaces 2 trunk Subversion 22189
        Mark Collette made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.0-Beta2 [ 10242 ]
        Fix Version/s 1.8.2-EE-GA_P02 [ 10226 ]
        Fix Version/s 1.8.3 [ 10211 ]
        Assignee Priority P1
        Resolution Fixed [ 1 ]
        Assignee Mark Collette [ mark.collette ]
        Mark Collette made changes -
        Summary action event not called for components in panelTab label when using c:forEach Static panelTabSet non-selected tab label facet not decoding
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22205 Thu Aug 19 08:37:37 MDT 2010 arran.mccullough ICE-5999: Static panelTabSet non-selected tab label facet not decoding
        Files Changed
        Commit graph MODIFY /icefaces/scratchpads/patches/sf-9305/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSet.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22214 Fri Aug 20 13:47:37 MDT 2010 mark.collette ICE-5999 : Static panelTabSet non-selected tab label facet not decoding
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/samples/component-showcase/web/WEB-INF/includes/examples/panel/panelTabSet-dynamic.xhtml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22215 Fri Aug 20 13:50:51 MDT 2010 mark.collette ICE-5999 : Static panelTabSet non-selected tab label facet not decoding
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSet.java
        Hide
        Mark Collette added a comment -

        Deryk pointed out that I had accidentally committed the wrong file to icefaces 2, for this fix. Turns out that I had committed a test file, for reproducing the issue, and not even committed the actual code fix. First commit here is to roll back the damage, and the second commit is the actual fix.

        icefaces 2 trunk
        Subversion 22214
        Subversion 22215

        Show
        Mark Collette added a comment - Deryk pointed out that I had accidentally committed the wrong file to icefaces 2, for this fix. Turns out that I had committed a test file, for reproducing the issue, and not even committed the actual code fix. First commit here is to roll back the damage, and the second commit is the actual fix. icefaces 2 trunk Subversion 22214 Subversion 22215
        Ken Fyten made changes -
        Fix Version/s 2.0.0 [ 10230 ]
        Fix Version/s 1.8.2-EE-GA_P02 [ 10226 ]
        Fix Version/s 1.8.3 [ 10211 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P1

          People

          • Assignee:
            Mark Collette
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: