ICEfaces
  1. ICEfaces
  2. ICE-5992

Allow arbitrary components in menuItem

          Details

          • Type: New Feature New Feature
          • Status: Closed
          • Priority: Major Major
          • Resolution: Invalid
          • Affects Version/s: None
          • Fix Version/s: None
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            icefaces2 compat
          • Affects:
            Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial

            Description

            For menu items, that are not at the top level, and which are leaf nodes, meaning that they have no children, add ability to have arbitrary component inside the menu item. This will replace any rendering of the link, label, icon, arrows, etc. The arbitrary component will be specified by placing it within a facet named "content".

            There will likely be practical, implementation detail specific, limitations on which components may be placed within the menuItem. Most likely, components that themselves have popup behaviours will not work, and would require specific integration efforts to function.

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Mark Collette added a comment -

              Modified the MenuItemRenderer to make use of the content facet, and render that in place of the usual anchor, span, img tags. There is still a problem with the background colour styling not showing, and with clicks on the content component causing the menu to hide.

              Check-in of interim release of code from the morning.

              Subversion 22172

              Show
              Mark Collette added a comment - Modified the MenuItemRenderer to make use of the content facet, and render that in place of the usual anchor, span, img tags. There is still a problem with the background colour styling not showing, and with clicks on the content component causing the menu to hide. Check-in of interim release of code from the morning. Subversion 22172
              Hide
              Permalink
              Mark Collette added a comment -

              Modified the javascript so that clicks within the content facet would not make the menus hide. To facilitate that, and to enable application styling, added a iceMnuItmCont style class, rendered on the div of menu items that have a content facet. This is as opposed to the regular iceMnuItm style class. Even before adding the new style class, keyboard navigation through content menu items did not work. With the style class, it broke even more. So, modified the menu keyboard navigation to support content menu items. Updated the themes to style iceMnuItmCont just like iceMnuItm.

              Subversion 22221

              Show
              Mark Collette added a comment - Modified the javascript so that clicks within the content facet would not make the menus hide. To facilitate that, and to enable application styling, added a iceMnuItmCont style class, rendered on the div of menu items that have a content facet. This is as opposed to the regular iceMnuItm style class. Even before adding the new style class, keyboard navigation through content menu items did not work. With the style class, it broke even more. So, modified the menu keyboard navigation to support content menu items. Updated the themes to style iceMnuItmCont just like iceMnuItm. Subversion 22221
              Hide
              Permalink
              Mark Collette added a comment -

              Accidentally committed a fix for ICE-5991 under this jira. This has become a catch-all for a bunch of issues, many of which are really pertaining to ICE-5991.
              Subversion 22233

              Show
              Mark Collette added a comment - Accidentally committed a fix for ICE-5991 under this jira. This has become a catch-all for a bunch of issues, many of which are really pertaining to ICE-5991 . Subversion 22233
              Hide
              Permalink
              Mark Collette added a comment -

              The code for this exists on an ICEfaces 2 specific branch, so we might just do this for ICEfaces 2 and not 1.8.x.

              The outstanding issue for the menu code is to resolve the issue where we couldn't get menus to auto-size for IE6. There may be a way to apply the width hard-coding only to IE6, and let everything else auto-size. Then we could take this content facet code, sub-items arrow code and auto-sizing code, and commit it all together to trunk.

              Show
              Mark Collette added a comment - The code for this exists on an ICEfaces 2 specific branch, so we might just do this for ICEfaces 2 and not 1.8.x. The outstanding issue for the menu code is to resolve the issue where we couldn't get menus to auto-size for IE6. There may be a way to apply the width hard-coding only to IE6, and let everything else auto-size. Then we could take this content facet code, sub-items arrow code and auto-sizing code, and commit it all together to trunk.
              Hide
              Permalink
              Ken Fyten added a comment -

              Marking as Closed / Invalid as part of legacy ICEfaces ICE / Compat component JIRA cleanup.

              Note: This issue may be resolved in a newer ICEfaces release, available here: http://www.icesoft.org/java/downloads/icefaces-downloads.jsf

              If the issue persists with the current ICEfaces release, please create a new JIRA for it.

              Show
              Ken Fyten added a comment - Marking as Closed / Invalid as part of legacy ICEfaces ICE / Compat component JIRA cleanup. Note: This issue may be resolved in a newer ICEfaces release, available here: http://www.icesoft.org/java/downloads/icefaces-downloads.jsf If the issue persists with the current ICEfaces release, please create a new JIRA for it.

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Mark Collette
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: