Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.0-Beta2
-
Fix Version/s: 2.0-Beta2
-
Component/s: None
-
Labels:None
-
Environment:Icefaces2 revision# 22069 - 22076
-
Assignee Priority:P2
Description
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
Show
Mandeep Hayher
added a comment - As mentioned in jira ICE-3376 , "We render a div to hold all of the hidden fields now, but not setting display: none on the div can cause the div to affect the layout."
But if you look at ICE-3376 in firebug, div with id="iceformhdnFldsDiv" has no style attribute = display:none.
I found the change (r22059) that caused the test to fail. We switched the compat form rendering out a the hidden fields in a form from <div style='display: none'> to a <span>. I assume this was done because the span containing hidden fields doesn't adjust the layout in any meaningful way which means we no longer need the style applied.
If that's the case, then we either need to change the test script to account for this or deprecate the test altogether (unless it's testing something else meaningful).
Show
Deryk Sinotte
added a comment - I found the change (r22059) that caused the test to fail. We switched the compat form rendering out a the hidden fields in a form from <div style='display: none'> to a <span>. I assume this was done because the span containing hidden fields doesn't adjust the layout in any meaningful way which means we no longer need the style applied.
If that's the case, then we either need to change the test script to account for this or deprecate the test altogether (unless it's testing something else meaningful).
Assigning back to QA to either modify the test if deemed appropriate.
Show
Deryk Sinotte
added a comment - Assigning back to QA to either modify the test if deemed appropriate.
Editing comment - wrong JIRA.
ICE-3376 removed from repo\qa\trunk\Regression-Icefaces2\Nightly.
Show
Mandeep Hayher
added a comment - ICE-3376 removed from repo\qa\trunk\Regression-Icefaces2\Nightly.
I can't see what the problem with this case is. There are no styles defined in the page. Only a single style sheet which, for me, is being properly loaded as of revision 22223:
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core"
xmlns:ice="http://www.icesoft.com/icefaces/component"
xmlns:ui="http://java.sun.com/jsf/facelets">
<h:head><title>
ICE-3376</title><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></meta>
<h:outputScript name="jsf.js" library="javax.faces"/>
<link href="./xmlhttp/css/xp/xp.css" rel="stylesheet" type="text/css" />
</h:head>
<h:body>
<ice:form id="iceform">
<ice:outputText id="text" value="
ICE-3376"/><br/><ice:commandButton id="btn" value="Button"/>
</ice:form>
</h:body>
</html>
There are class= attributes being rendered out to the outputText and commandButton markup. Perhaps I don't fully understand what the test is looking for.