ICEfaces
  1. ICEfaces
  2. ICE-5960

improve loadBundle lazy init

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Beta1
          • Fix Version/s: 3.3
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            ICEfaces 2.0, MyFaces 2.0
          • Assignee Priority:
            P1
          • Affects:
            Documentation (User Guide, Ref. Guide, etc.)

            Description


            LoadBundle has been modified so that transient fields are recreated after de-Serialization, however the encodeBegin() and getBundle() methods are not cleanly factored since the side-effects need to be considered for performance. Any additional work on this component should include refactoring these two functions.

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Ted Goddard added a comment -

              Not necessary to fix for 2.0, just a code-cleanup task.

              Show
              Ted Goddard added a comment - Not necessary to fix for 2.0, just a code-cleanup task.
              Hide
              Permalink
              Mircea Toma added a comment -

              Factored out duplicate code into updateBundle() private method. Clarified boolean tests.

              Show
              Mircea Toma added a comment - Factored out duplicate code into updateBundle() private method. Clarified boolean tests.
              Hide
              Permalink
              Ken Fyten added a comment - - edited

              New regression failures that seem likely to be related to this change:

              Icefaces3 trunk revision# 33414
Server: tomcat6
Browser: FF3.6, IE7 & GoogleChrome24

New failures:  ICE-3790 (All Browsers) - 'Spanish' button doesn't change all text visible to complete spanish (only half part of text gets translated).
                         ICE-2763 (All Browsers) - On page load, 'message 2' text is not present on page, must click 'message 2 radio button' to render; dynamic message rendering on proper container (message 2 was sitting on the dynamic message's container).

              Load bundle is not working correctly.

              Show
              Ken Fyten added a comment - - edited New regression failures that seem likely to be related to this change: Icefaces3 trunk revision# 33414 Server: tomcat6 Browser: FF3.6, IE7 & GoogleChrome24 New failures: ICE-3790 (All Browsers) - 'Spanish' button doesn't change all text visible to complete spanish (only half part of text gets translated). ICE-2763 (All Browsers) - On page load, 'message 2' text is not present on page, must click 'message 2 radio button' to render; dynamic message rendering on proper container (message 2 was sitting on the dynamic message's container). Load bundle is not working correctly.
              Hide
              Permalink
              Mircea Toma added a comment -

              Update the bundle map into the JSF request map to make sure the new values are picked up.

              Show
              Mircea Toma added a comment - Update the bundle map into the JSF request map to make sure the new values are picked up.

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Ted Goddard
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: