ICEfaces
  1. ICEfaces
  2. ICE-5959

Datapaginator: Wrong rendering with vertical setting

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.2
    • Fix Version/s: 2.0.1
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      N/A

      Description

      When using the datapaginator with vertical setting, the buttons forward, fast-forward and last are rendered in the same row of the page facets.

      I don't know if the problem has been already fixed, but here there is my fix in the DataPaginatorRenderer:

          protected void renderScroller(FacesContext facesContext, UIComponent uiComponent) throws IOException {

                ....

                  Element td = domContext.createElement(HTML.TD_ELEM);
                  tr.appendChild(td);
                  Element paginatorTable = domContext.createElement(HTML.TABLE_ELEM);
                  td.appendChild(paginatorTable);
                  renderPaginator(facesContext, uiComponent, paginatorTable,
                                  domContext);
              }
              
              // FIX BUG for vertical setting
              // Horizontal shares a table row, but for vertical,
              // have them each auto-create their own table row
              if (scroller.isVertical()) {
                  tr = null;
              }

              handleFacet(facesContext, scroller, domContext, table, tr,
                          scrollButtonCellClass, scroller.getNext(),
                          DataPaginator.FACET_NEXT);
              
              ....

          }

        Issue Links

          Activity

          Hide
          Carlo Guglielmin added a comment -

          Fell through the cracks for a long while, but this was finally fixed as per ICE-6704

          Show
          Carlo Guglielmin added a comment - Fell through the cracks for a long while, but this was finally fixed as per ICE-6704
          Hide
          yip.ng added a comment -

          Revision: 24262


          Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/datapaginator/DataPaginatorRenderer.java

          Show
          yip.ng added a comment - Revision: 24262 Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/datapaginator/DataPaginatorRenderer.java

            People

            • Assignee:
              Unassigned
              Reporter:
              Alessandro Craviolatti
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: