ICEfaces
  1. ICEfaces
  2. ICE-5814

New LinkButton ACE component

          Details

          • Type: New Feature New Feature
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Alpha3
          • Fix Version/s: 2.0-Beta2, 2.0.0
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            ICEFaces 2.0 ACE Components
          • Affects:
            Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial

            Description

            Add a linkButton component to the ACE component suite.

              Activity

              Ascending order - Click to sort in descending order
              6 older comments
              Hide
              Permalink
              Ken Fyten added a comment -

              What if we set a flag in the bridge during the onclick event handling JS that the bridge would use to ignore the view disposal call during the next onbeforeunload event call (and then clears the flag)?

              Does the onclick event handler get called before the onbeforeunload one?

              Show
              Ken Fyten added a comment - What if we set a flag in the bridge during the onclick event handling JS that the bridge would use to ignore the view disposal call during the next onbeforeunload event call (and then clears the flag)? Does the onclick event handler get called before the onbeforeunload one?
              Hide
              Permalink
              Mircea Toma added a comment -

              The fourth link renders this markup:

              <a onclick="ice.component.commandlink.theInsideClick(event); return false;" id="success" href="http://www.icefaces.org">Link ID Test for IE</a>

              The reason why the default action is not canceled is caused by an exception that occurs in the onclick handler. The 'ice.component.commandlink.theInsideClick' function does not exist which causes the exception to be thrown, and consequently 'false' is not return by the handler so that default action is blocked.

              Just replacing the onclick handler with 'return false;' code proves to be working fine, meaning canceling the navigation to the href-ed page, does not occur. This is true for IE6 and IE7 and of course, the rest of the browsers.

              Show
              Mircea Toma added a comment - The fourth link renders this markup: <a onclick="ice.component.commandlink.theInsideClick(event); return false;" id="success" href="http://www.icefaces.org">Link ID Test for IE</a> The reason why the default action is not canceled is caused by an exception that occurs in the onclick handler. The 'ice.component.commandlink.theInsideClick' function does not exist which causes the exception to be thrown, and consequently 'false' is not return by the handler so that default action is blocked. Just replacing the onclick handler with 'return false;' code proves to be working fine, meaning canceling the navigation to the href-ed page, does not occur. This is true for IE6 and IE7 and of course, the rest of the browsers.
              Hide
              Permalink
              Ken Fyten added a comment -

              Re-opened. Back to Greg.

              Show
              Ken Fyten added a comment - Re-opened. Back to Greg.
              Hide
              Permalink
              Ken Fyten added a comment -

              Reminder that we wil need a rime and sam skin resources created for this component. The rime skin should be based on the current styling in the rime.css file for 1.8, for the ice:outputLink component.

              Show
              Ken Fyten added a comment - Reminder that we wil need a rime and sam skin resources created for this component. The rime skin should be based on the current styling in the rime.css file for 1.8, for the ice:outputLink component.
              Hide
              Permalink
              Ken Fyten added a comment -

              linkButton component has the following noted outstanding tasks/issues:

              Component Name:

              • Rename/repackage component to "LinkButton", incl. comp. name, tag name ("linkButton"), all classnames, componentFamily, etc.
              • Change componentFamily to "org.icefaces.component.LinkButton"

              Attributes:

              • Following attributes need description in tag doc and review as to whether they should be kept, renamed, etc.:
              • rev
              • image (should be in CSS as per changes Judy has made recently to checkboxButton)
              • shape
              • name (don't think we need this, it's for grouping buttons)
              • value (what is the value for?)
              • rel

              Documentation:

              • Component level descriptive doc missing from TLD/taglib doc. This can be brief summation with link to the Wiki doc page.
              • The following attributes have insufficient doc:
              • singleSubmit (use std. description)
              • hreg
              • hreflang
              • action
              • others with no descriptions...

              linkButton Renderer Impl Notes:
              Check for these issues that were found in checkboxButton:

              • decode: if (requestParameterMap.containsKey("ice.event.captured")) { but doesn't use it (remove?)
              • encodeBegin: writer.write(checkbox.getLabel()); Should this use writeText to escape the label?
              • Reduce component property evaluations. Eg: findCheckboxLabel(Checkbox) by cacheing property values with local var.
              Show
              Ken Fyten added a comment - linkButton component has the following noted outstanding tasks/issues: Component Name: Rename/repackage component to "LinkButton", incl. comp. name, tag name ("linkButton"), all classnames, componentFamily, etc. Change componentFamily to "org.icefaces.component.LinkButton" Attributes: Following attributes need description in tag doc and review as to whether they should be kept, renamed, etc.: rev image (should be in CSS as per changes Judy has made recently to checkboxButton) shape name (don't think we need this, it's for grouping buttons) value (what is the value for?) rel Documentation: Component level descriptive doc missing from TLD/taglib doc. This can be brief summation with link to the Wiki doc page. The following attributes have insufficient doc: singleSubmit (use std. description) hreg hreflang action others with no descriptions... Wiki user doc: Missing user documentation page altogether. Should mimic the general contents and completeness from http://developer.yahoo.com/yui/autocomplete/ , for example. See also http://wiki.icefaces.org/display/facesDev/DateTime+Entry . General config and usage should be covered, typical use-cases illustrated and described. linkButton Renderer Impl Notes: Check for these issues that were found in checkboxButton: decode: if (requestParameterMap.containsKey("ice.event.captured")) { but doesn't use it (remove?) encodeBegin: writer.write(checkbox.getLabel()); Should this use writeText to escape the label? Reduce component property evaluations. Eg: findCheckboxLabel(Checkbox) by cacheing property values with local var.

                People

                • Assignee:
                  Greg Dick
                  Reporter:
                  Greg Dick
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: