ICEfaces
  1. ICEfaces
  2. ICE-5751

Need to exclude commons-logging transitive servlet-api dependency in pom.xml for compatibility components

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Alpha3
          • Fix Version/s: 2.0-Alpha3, 2.0.0
          • Component/s: Tool Integrations
          • Labels:
            None
          • Environment:
            N/A

            Description

            This is actually the fault of whoever created the pom.xml for commons-logging, because they have servlet-api as a compile time dependency in the pom.xml for commons-logging. Since the ICEfaces compatibility components pom.xml includes a dependency on commons-logging, we end up getting servlet-api-2.3.jar in WEB-INF/lib for deployed webapps and portlets developed with Maven.

            The fix is simple -- just add an exclusion for servlet-api in the pom.xml file for the compatibility components:


            Index: icefaces-compat.pom
            ===================================================================
            --- icefaces-compat.pom (revision 21431)
            +++ icefaces-compat.pom (working copy)
            @@ -58,6 +58,10 @@
                        <artifactId>log4j</artifactId>
                        <groupId>log4j</groupId>
                    </exclusion>
            + <exclusion>
            + <groupId>javax.servlet</groupId>
            + <artifactId>servlet-api</artifactId>
            + </exclusion>
                   </exclusions>
                 </dependency>
                     
            @@ -69,4 +73,4 @@
                 </dependency>
              
               </dependencies>
            -</project>
            \ No newline at end of file
            +</project>

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Deryk Sinotte added a comment -

              Assigning to Judy to test and make the adjustment that Neil has suggested.

              Show
              Deryk Sinotte added a comment - Assigning to Judy to test and make the adjustment that Neil has suggested.
              Hide
              Permalink
              Judy Guglielmin added a comment -

              change made to icefaces-compat.pom for this. Will be updated to snapshots repository when A3 is released. For now workaround it by adding the exclusion to the icefacse-compat dependency in the pom (like the examples for compat do in their build poms).

              Show
              Judy Guglielmin added a comment - change made to icefaces-compat.pom for this. Will be updated to snapshots repository when A3 is released. For now workaround it by adding the exclusion to the icefacse-compat dependency in the pom (like the examples for compat do in their build poms).

                People

                • Assignee:
                  Judy Guglielmin
                  Reporter:
                  Neil Griffin
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: