ICEfaces
  1. ICEfaces
  2. ICE-5730

Update faces-config.xml files to use JSF 2 schemas

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-Alpha2
    • Fix Version/s: 2.0-Alpha3, 2.0.0
    • Component/s: ICE-Components, Sample Apps
    • Labels:
      None
    • Environment:
      Glimmer, Sparkle

      Description

      Upgrading all glimmer/sparkle faces-config.xmls to use the JSF 2 schema, instead of the old JSF 1.1 DTD. Also update generator to emit sparkle faces-config.xml with schema.

      One question is whether glimmer compat should do this, both for the components jar and for the sample apps. We will make the change, but then need to test to make sure things still work.

        Activity

        Hide
        Mark Collette added a comment -

        In glimmer and glimmer/samples are already using the proper new JSF 2 schema in the faces-config.xml files.

        In glimmer/compat/core and glimmer/compat/samples, the faces-config.xml are already correct.

        In glimmer/compat/components, the generated icefaces-taglib.xml is correct, but the faces-config.xml and icefaces_component.tld are still using old DTDs.

        In sparkle/generator, the components.tld, faces-config.xml, icefaces-taglib.xml files are still using old TLDs.

        Show
        Mark Collette added a comment - In glimmer and glimmer/samples are already using the proper new JSF 2 schema in the faces-config.xml files. In glimmer/compat/core and glimmer/compat/samples, the faces-config.xml are already correct. In glimmer/compat/components, the generated icefaces-taglib.xml is correct, but the faces-config.xml and icefaces_component.tld are still using old DTDs. In sparkle/generator, the components.tld, faces-config.xml, icefaces-taglib.xml files are still using old TLDs.
        Hide
        Mark Collette added a comment -

        The sparkle faces-config.xml file, not using the new schema, keeps the new JSF 2 annotations from being scanned in sparkle classes. That is why the faces-config.xml files need to be updated.

        Show
        Mark Collette added a comment - The sparkle faces-config.xml file, not using the new schema, keeps the new JSF 2 annotations from being scanned in sparkle classes. That is why the faces-config.xml files need to be updated.
        Hide
        Mark Collette added a comment -

        The glimmer/compat/components files seem pretty hard to change. The faces-config.xml processing seems tied to the usage od a DTD. Partially because of the generator and partially because of the heavy usage of ENTITY references, which are only supported in DTDs, not schemas. This appears to be the relevant source file:

        glimmer\compat\component-metadata\src\main\resources\conf\faces-config-base.xml

        Show
        Mark Collette added a comment - The glimmer/compat/components files seem pretty hard to change. The faces-config.xml processing seems tied to the usage od a DTD. Partially because of the generator and partially because of the heavy usage of ENTITY references, which are only supported in DTDs, not schemas. This appears to be the relevant source file: glimmer\compat\component-metadata\src\main\resources\conf\faces-config-base.xml
        Hide
        Mark Collette added a comment -

        Leaving the glimmer/compat/component generated faces-config.xml and TLD file alone.

        Updated the sparkle generator, so the faces-config.xml, Facelets taglib.xml, and TLD file will use their respective new JSF 2 schemas.

        Subversion 21448

        Show
        Mark Collette added a comment - Leaving the glimmer/compat/component generated faces-config.xml and TLD file alone. Updated the sparkle generator, so the faces-config.xml, Facelets taglib.xml, and TLD file will use their respective new JSF 2 schemas. Subversion 21448

          People

          • Assignee:
            Mark Collette
            Reporter:
            Mark Collette
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: