ICEfaces
  1. ICEfaces
  2. ICE-5683

Merge icefaces-compat.jar and icefaces-compat-comps.jar into a single icefaces-compat.jar

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-Alpha3
    • Fix Version/s: 2.0-Beta1, 2.0.0
    • Component/s: Release
    • Labels:
      None
    • Environment:
      ICEfaces 2.0 Compatibility mode
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration

      Description

      As there are very few cases where an application would want to use the compat.jar APIs and not also be using the compat-comps.jar components, it would make things simpler to combine these two jars into a single icefaces-compat.jar.

      This is planned prior to beta.

        Issue Links

          Activity

          Hide
          Mircea Toma added a comment -

          Moved compat/core faces-config setup into compat/component-metadata faces-config generation. Changed compat/core build to invoke compat/components targets for building the components. Removed icefaces-compat-components.jar file from the list of libraries that compat/samples need.

          Show
          Mircea Toma added a comment - Moved compat/core faces-config setup into compat/component-metadata faces-config generation. Changed compat/core build to invoke compat/components targets for building the components. Removed icefaces-compat-components.jar file from the list of libraries that compat/samples need.
          Hide
          Ken Fyten added a comment - - edited

          Unfortunately, the commit breaks the Glimmer 'ant world' build.

          Glimmer build failing on fresh checkout:

          [javac]
          [javac] C:\svn\ossrepo\icefaces\scratchpads\glimmer\compat\components\src\main\java\com\icesoft\faces\component\comman
          erer.java:28: package com.icesoft.faces.context does not exist
          [javac] import com.icesoft.faces.context.DOMContext;
          [javac] ^
          [javac] C:\svn\ossrepo\icefaces\scratchpads\glimmer\compat\components\src\main\java\com\icesoft\faces\component\comman
          erer.java:29: package com.icesoft.faces.renderkit.dom_html_basic does not exist
          [javac] import com.icesoft.faces.renderkit.dom_html_basic.HTML;
          [javac] ^
          [javac] C:\svn\ossrepo\icefaces\scratchpad

          Show
          Ken Fyten added a comment - - edited Unfortunately, the commit breaks the Glimmer 'ant world' build. Glimmer build failing on fresh checkout: [javac] [javac] C:\svn\ossrepo\icefaces\scratchpads\glimmer\compat\components\src\main\java\com\icesoft\faces\component\comman erer.java:28: package com.icesoft.faces.context does not exist [javac] import com.icesoft.faces.context.DOMContext; [javac] ^ [javac] C:\svn\ossrepo\icefaces\scratchpads\glimmer\compat\components\src\main\java\com\icesoft\faces\component\comman erer.java:29: package com.icesoft.faces.renderkit.dom_html_basic does not exist [javac] import com.icesoft.faces.renderkit.dom_html_basic.HTML; [javac] ^ [javac] C:\svn\ossrepo\icefaces\scratchpad
          Hide
          Ken Fyten added a comment -

          Reverting to 21861 seems to fix it for me.

          I suspect this modification to the build.xml is causing the trouble:

          r21862 | mircea.toma | 2010-07-07 16:14:25 -0600 (Wed, 07 Jul 2010) | 1 line
          Changed paths:
          M /icefaces/scratchpads/glimmer/compat/component-metadata/src/main/resources/com/icesoft/jsfmeta/templates/jsf11/resources/faces-config-rt.ftl
          M /icefaces/scratchpads/glimmer/compat/core/build.xml
          M /icefaces/scratchpads/glimmer/compat/samples/build-common.xml

          ICE-5683 Moved compat/core faces-config setup into compat/component-metadata faces-config generation. Changed compat/core build to invoke compat/components targets for building the components. Removed icefaces-compat-components.jar file from the list of libraries that compat/samples need.

          Ted.

          Show
          Ken Fyten added a comment - Reverting to 21861 seems to fix it for me. I suspect this modification to the build.xml is causing the trouble: r21862 | mircea.toma | 2010-07-07 16:14:25 -0600 (Wed, 07 Jul 2010) | 1 line Changed paths: M /icefaces/scratchpads/glimmer/compat/component-metadata/src/main/resources/com/icesoft/jsfmeta/templates/jsf11/resources/faces-config-rt.ftl M /icefaces/scratchpads/glimmer/compat/core/build.xml M /icefaces/scratchpads/glimmer/compat/samples/build-common.xml ICE-5683 Moved compat/core faces-config setup into compat/component-metadata faces-config generation. Changed compat/core build to invoke compat/components targets for building the components. Removed icefaces-compat-components.jar file from the list of libraries that compat/samples need. Ted.
          Hide
          Mircea Toma added a comment -

          The last problem was caused by the dependency that compat/components classes have on the compat/core classes. Before the refactoring the classes in compat/core were already compiled and thus referenced by the compat/components compile target. The solution applied makes sure that compat/core classes are compiled first before the classes in compat/components are compiled.

          Show
          Mircea Toma added a comment - The last problem was caused by the dependency that compat/components classes have on the compat/core classes. Before the refactoring the classes in compat/core were already compiled and thus referenced by the compat/components compile target. The solution applied makes sure that compat/core classes are compiled first before the classes in compat/components are compiled.

            People

            • Assignee:
              Mircea Toma
              Reporter:
              Ken Fyten
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: