ICEfaces
  1. ICEfaces
  2. ICE-5675

ICEfaces 2 - remove Mojarra JSF 2.0.2 issue workarounds reminder

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Alpha2
          • Fix Version/s: 3.3
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            ICEfaces, JSF 2.0.2
          • Assignee Priority:
            P3

            Description

            Any hacks that are in place as workarounds for JSF 2.0.2 issues should be removed in ICEfaces 2.0 final based on JSF 2.0.3.

              Issue Links

              blocks

              Bug - A problem which impairs or prevents the functions of the product. ICE-5157 ICEfaces 2.0: ClassCastException during navigation

              • Major - Major loss of function.
              • Closed

              Bug - A problem which impairs or prevents the functions of the product. ICE-5728 ViewState is not applied to all forms

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Ted Goddard created issue -
                Hide
                Permalink
                Ted Goddard added a comment -

                Assigning to Deryk to organize a hack removal shortly before 2.0 final.

                Show
                Ted Goddard added a comment - Assigning to Deryk to organize a hack removal shortly before 2.0 final.
                Ted Goddard made changes -
                Field Original Value New Value
                Salesforce Case []
                Fix Version/s 2.0.0 [ 10230 ]
                Assignee Deryk Sinotte [ deryk.sinotte ]
                Hide
                Permalink
                Ted Goddard added a comment -

                core/src/main/java/org/icefaces/facelets/tag/icefaces/core/ConfigHandler.java contains the following hack for ICE-5157:

                + //TODO: remove when JSF 2.0 Partial State Saving fixed
                + //touched in the head
                + facesContext.getViewRoot().addComponentResource( facesContext,
                + new UIOutput(), "head" );

                Committed revision 21346

                Show
                Ted Goddard added a comment - core/src/main/java/org/icefaces/facelets/tag/icefaces/core/ConfigHandler.java contains the following hack for ICE-5157 : + //TODO: remove when JSF 2.0 Partial State Saving fixed + //touched in the head + facesContext.getViewRoot().addComponentResource( facesContext, + new UIOutput(), "head" ); Committed revision 21346
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #21351 Fri Apr 30 09:40:23 MDT 2010 deryk.sinotte ICE-5675: touch both the head and body sections to ensure state saving strategy is chosen consistently
                Files Changed
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/facelets/tag/icefaces/core/ConfigHandler.java
                Deryk Sinotte made changes -
                Link This issue blocks ICE-5157 [ ICE-5157 ]
                Mircea Toma made changes -
                Link This issue depends on ICE-5728 [ ICE-5728 ]
                Mircea Toma made changes -
                Link This issue depends on ICE-5728 [ ICE-5728 ]
                Mircea Toma made changes -
                Link This issue blocks ICE-5728 [ ICE-5728 ]
                Ken Fyten made changes -
                Fix Version/s 2.1 [ 10241 ]
                Fix Version/s 2.0.0 [ 10230 ]
                Hide
                Permalink
                Ken Fyten added a comment -

                Need to review state of Mojarra JSF work-arounds prior to final release. At this point, we don't expect many/any changes prior to JSF 2.2.

                Show
                Ken Fyten added a comment - Need to review state of Mojarra JSF work-arounds prior to final release. At this point, we don't expect many/any changes prior to JSF 2.2.
                Ken Fyten made changes -
                Summary ICEfaces 2.0 remove JSF 2.0.2 hacks ICEfaces 2 - remove Mojarra JSF 2.0.2 issue workarounds reminder
                Salesforce Case []
                Assignee Priority P3
                Hide
                Permalink
                Deryk Sinotte added a comment -

                Reviewing the relevant cases:

                The Mojarra test case is at http://java.net/jira/browse/JAVASERVERFACES-1427 (formerly https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=1427) and is still outstanding for the Mojarra 2.2 release so won't be fixed for 2.1 final. This means our current workaround for ICE-5157 needs to remain.

                The other case (ICE-5728) doesn't have a matching JIRA in the Mojarra tracking system so whatever fixes we have for that will need to remain as well.

                Show
                Deryk Sinotte added a comment - Reviewing the relevant cases: The Mojarra test case is at http://java.net/jira/browse/JAVASERVERFACES-1427 (formerly https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=1427 ) and is still outstanding for the Mojarra 2.2 release so won't be fixed for 2.1 final. This means our current workaround for ICE-5157 needs to remain. The other case ( ICE-5728 ) doesn't have a matching JIRA in the Mojarra tracking system so whatever fixes we have for that will need to remain as well.
                Ken Fyten made changes -
                Salesforce Case []
                Fix Version/s 3.1 [ 10312 ]
                Fix Version/s 3.0 [ 10241 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #28938 Fri May 04 10:23:57 MDT 2012 ted.goddard jsfHacks attribute for ConfigHandler (ICE-5675)
                Files Changed
                Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/facelets/tag/icefaces/core/ConfigHandler.java
                Ken Fyten made changes -
                Fix Version/s 3.2 [ 10338 ]
                Fix Version/s 3.1 [ 10312 ]
                Migration made changes -
                Fix Version/s 3.3 [ 10370 ]
                Fix Version/s 3.2 [ 10338 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #33475 Fri Feb 15 15:29:31 MST 2013 deryk.sinotte ICE-5675: removed fix for ICE-5157 as it is no longer needed
                Files Changed
                Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/facelets/tag/icefaces/core/ConfigHandler.java
                Hide
                Permalink
                Deryk Sinotte added a comment -

                Removed the hack we put in for ICE-5157. The original JSF JIRA says that it's fixed on both the 2.1 version we are using as well as on the 2.2 trunk. I ran a couple of our test cases and verified that removing the hack seems to be safe.

                Show
                Deryk Sinotte added a comment - Removed the hack we put in for ICE-5157 . The original JSF JIRA says that it's fixed on both the 2.1 version we are using as well as on the 2.2 trunk. I ran a couple of our test cases and verified that removing the hack seems to be safe.
                Hide
                Permalink
                Deryk Sinotte added a comment -

                Resolving as fixed.

                Show
                Deryk Sinotte added a comment - Resolving as fixed.
                Deryk Sinotte made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]

                  People

                  • Assignee:
                    Deryk Sinotte
                    Reporter:
                    Ted Goddard
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: