ICEfaces
  1. ICEfaces
  2. ICE-5675

ICEfaces 2 - remove Mojarra JSF 2.0.2 issue workarounds reminder

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-Alpha2
    • Fix Version/s: 3.3
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      ICEfaces, JSF 2.0.2
    • Assignee Priority:
      P3

      Description

      Any hacks that are in place as workarounds for JSF 2.0.2 issues should be removed in ICEfaces 2.0 final based on JSF 2.0.3.

        Issue Links

          Activity

          Hide
          Ted Goddard added a comment -

          Assigning to Deryk to organize a hack removal shortly before 2.0 final.

          Show
          Ted Goddard added a comment - Assigning to Deryk to organize a hack removal shortly before 2.0 final.
          Hide
          Ted Goddard added a comment -

          core/src/main/java/org/icefaces/facelets/tag/icefaces/core/ConfigHandler.java contains the following hack for ICE-5157:

          + //TODO: remove when JSF 2.0 Partial State Saving fixed
          + //touched in the head
          + facesContext.getViewRoot().addComponentResource( facesContext,
          + new UIOutput(), "head" );

          Committed revision 21346

          Show
          Ted Goddard added a comment - core/src/main/java/org/icefaces/facelets/tag/icefaces/core/ConfigHandler.java contains the following hack for ICE-5157 : + //TODO: remove when JSF 2.0 Partial State Saving fixed + //touched in the head + facesContext.getViewRoot().addComponentResource( facesContext, + new UIOutput(), "head" ); Committed revision 21346
          Hide
          Ken Fyten added a comment -

          Need to review state of Mojarra JSF work-arounds prior to final release. At this point, we don't expect many/any changes prior to JSF 2.2.

          Show
          Ken Fyten added a comment - Need to review state of Mojarra JSF work-arounds prior to final release. At this point, we don't expect many/any changes prior to JSF 2.2.
          Hide
          Deryk Sinotte added a comment -

          Reviewing the relevant cases:

          The Mojarra test case is at http://java.net/jira/browse/JAVASERVERFACES-1427 (formerly https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=1427) and is still outstanding for the Mojarra 2.2 release so won't be fixed for 2.1 final. This means our current workaround for ICE-5157 needs to remain.

          The other case (ICE-5728) doesn't have a matching JIRA in the Mojarra tracking system so whatever fixes we have for that will need to remain as well.

          Show
          Deryk Sinotte added a comment - Reviewing the relevant cases: The Mojarra test case is at http://java.net/jira/browse/JAVASERVERFACES-1427 (formerly https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=1427 ) and is still outstanding for the Mojarra 2.2 release so won't be fixed for 2.1 final. This means our current workaround for ICE-5157 needs to remain. The other case ( ICE-5728 ) doesn't have a matching JIRA in the Mojarra tracking system so whatever fixes we have for that will need to remain as well.
          Hide
          Deryk Sinotte added a comment -

          Removed the hack we put in for ICE-5157. The original JSF JIRA says that it's fixed on both the 2.1 version we are using as well as on the 2.2 trunk. I ran a couple of our test cases and verified that removing the hack seems to be safe.

          Show
          Deryk Sinotte added a comment - Removed the hack we put in for ICE-5157 . The original JSF JIRA says that it's fixed on both the 2.1 version we are using as well as on the 2.2 trunk. I ran a couple of our test cases and verified that removing the hack seems to be safe.
          Hide
          Deryk Sinotte added a comment -

          Resolving as fixed.

          Show
          Deryk Sinotte added a comment - Resolving as fixed.

            People

            • Assignee:
              Deryk Sinotte
              Reporter:
              Ted Goddard
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: