ICEfaces
  1. ICEfaces
  2. ICE-5664

Review use of Wrappers rather than directly subclassing interfaces.

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Alpha2
          • Fix Version/s: 2.0-Beta1, 2.0.0
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            ICEfaces 2 JSF 2

            Description

            We need to review our strategy of directly subclassing interfaces rather than using the supplied abstract wrappers for delegation:

            public class DOMRenderKit extends RenderKit vs public class DOMRenderKit extends RenderKitWrapper
            public class DOMResponseWriter extends ResponseWriter vs public class DOMResponseWriter extends ResponseWriterWrapper

            In many cases, using the wrapper would give us access to a delegate class where we could take advantage of existing code.

              Issue Links

              blocks

              Improvement - An improvement or enhancement to an existing feature or task. ICE-5679 Standardize how ICEfaces detects and uses encoding

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Deryk Sinotte created issue -
                Deryk Sinotte made changes -
                Field Original Value New Value
                Salesforce Case []
                Fix Version/s 2.0-Beta [ 10231 ]
                Deryk Sinotte made changes -
                Link This issue blocks ICE-5679 [ ICE-5679 ]
                Ken Fyten made changes -
                Assignee Deryk Sinotte [ deryk.sinotte ]
                Deryk Sinotte made changes -
                Salesforce Case []
                Component/s Framework [ 10013 ]
                Assignee Priority P1
                Hide
                Permalink
                Deryk Sinotte added a comment -

                I've done an initial survey of the various Wrapper classes provided by JSF 2.0 and checked our code for usage. Here's what I've determined so far:

                Classes that provide a wrapper but that we don't currently extend or use:

                ApplicationWrapper
                ExceptionHandlerWrapper
                ExternalContextWrapper
                ResourceWrapper
                StateManagerWrapper
                ViewHandlerWrapper
                VisitContextWrapper

                Classes using Wrappers:

                DOMPartialViewContext extends PartialViewContextWrapper (may be able to clean up some overridden methods that aren't required)

                WriteViewStateOnPageLoad extends FacesContextWrapper

                Classes that should use Wrappers but are directly extending:

                CompatDOMPartialViewContext extends PartialViewContext
                DOMRenderKit extends RenderKit
                ICEfacesResourceHandler extends ResourceHandler
                ICEpushResourceHandler extends ResourceHandler
                BasicResponseWriter extends ResponseWriter
                DOMResponseWriter extends ResponseWriter

                Show
                Deryk Sinotte added a comment - I've done an initial survey of the various Wrapper classes provided by JSF 2.0 and checked our code for usage. Here's what I've determined so far: Classes that provide a wrapper but that we don't currently extend or use: ApplicationWrapper ExceptionHandlerWrapper ExternalContextWrapper ResourceWrapper StateManagerWrapper ViewHandlerWrapper VisitContextWrapper Classes using Wrappers: DOMPartialViewContext extends PartialViewContextWrapper (may be able to clean up some overridden methods that aren't required) WriteViewStateOnPageLoad extends FacesContextWrapper Classes that should use Wrappers but are directly extending: CompatDOMPartialViewContext extends PartialViewContext DOMRenderKit extends RenderKit ICEfacesResourceHandler extends ResourceHandler ICEpushResourceHandler extends ResourceHandler BasicResponseWriter extends ResponseWriter DOMResponseWriter extends ResponseWriter
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #21776 Mon Jun 21 11:32:33 MDT 2010 deryk.sinotte ICE-5664: convert to extending JSF 2 Wrapper classes where appropriate
                Files Changed
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/push/servlet/ICEfacesResourceHandler.java
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/push/servlet/ICEpushResourceHandler.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #21802 Fri Jun 25 08:52:52 MDT 2010 deryk.sinotte ICE-5664: adapting ResponseWriters to use Wrappers so that we can take advantage of delegates to determine content type and encoding
                Files Changed
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/context/DOMResponseWriter.java
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/context/BasicResponseWriter.java
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/context/DOMPartialViewContext.java
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/render/DOMRenderKit.java
                Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/java/com/icesoft/faces/context/CompatDOMPartialViewContext.java
                Hide
                Permalink
                Deryk Sinotte added a comment -

                I've checked in the changes to the ResponseWriters so now everything that should likely be using wrappers is now converted.

                Show
                Deryk Sinotte added a comment - I've checked in the changes to the ResponseWriters so now everything that should likely be using wrappers is now converted.
                Deryk Sinotte made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #21815 Mon Jun 28 14:53:43 MDT 2010 deryk.sinotte ICE-5664: revert removal of getResponseOutputWriter method so that view state marker replacement works in compat mode
                Files Changed
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/context/DOMPartialViewContext.java
                Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/java/com/icesoft/faces/context/CompatDOMPartialViewContext.java
                Ken Fyten made changes -
                Fix Version/s 2.0.0 [ 10230 ]
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]
                Assignee Priority P1

                  People

                  • Assignee:
                    Deryk Sinotte
                    Reporter:
                    Deryk Sinotte
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: