ICEfaces
  1. ICEfaces
  2. ICE-5664

Review use of Wrappers rather than directly subclassing interfaces.

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Alpha2
          • Fix Version/s: 2.0-Beta1, 2.0.0
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            ICEfaces 2 JSF 2

            Description

            We need to review our strategy of directly subclassing interfaces rather than using the supplied abstract wrappers for delegation:

            public class DOMRenderKit extends RenderKit vs public class DOMRenderKit extends RenderKitWrapper
            public class DOMResponseWriter extends ResponseWriter vs public class DOMResponseWriter extends ResponseWriterWrapper

            In many cases, using the wrapper would give us access to a delegate class where we could take advantage of existing code.

              Issue Links

              blocks

              Improvement - An improvement or enhancement to an existing feature or task. ICE-5679 Standardize how ICEfaces detects and uses encoding

              • Major - Major loss of function.
              • Closed

                Activity

                Repository Revision Date User Message
                ICEsoft Public SVN Repository #21815 Mon Jun 28 14:53:43 MDT 2010 deryk.sinotte ICE-5664: revert removal of getResponseOutputWriter method so that view state marker replacement works in compat mode
                Files Changed
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/context/DOMPartialViewContext.java
                Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/java/com/icesoft/faces/context/CompatDOMPartialViewContext.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #21802 Fri Jun 25 08:52:52 MDT 2010 deryk.sinotte ICE-5664: adapting ResponseWriters to use Wrappers so that we can take advantage of delegates to determine content type and encoding
                Files Changed
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/context/DOMResponseWriter.java
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/context/BasicResponseWriter.java
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/context/DOMPartialViewContext.java
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/render/DOMRenderKit.java
                Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/java/com/icesoft/faces/context/CompatDOMPartialViewContext.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #21776 Mon Jun 21 11:32:33 MDT 2010 deryk.sinotte ICE-5664: convert to extending JSF 2 Wrapper classes where appropriate
                Files Changed
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/push/servlet/ICEfacesResourceHandler.java
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/push/servlet/ICEpushResourceHandler.java

                  People

                  • Assignee:
                    Deryk Sinotte
                    Reporter:
                    Deryk Sinotte
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: