ICEfaces
  1. ICEfaces
  2. ICE-5308

Problem with views with collapsible panel

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.8.2
          • Fix Version/s: 1.8.2-EE-GA_P01, 1.8.3
          • Component/s: None
          • Labels:
            None
          • Environment:
            Icefaces rev 19313
          • Workaround Exists:
            Yes
          • Workaround Description:
            Hide
            Patch

            Index: PanelCollapsibleRenderer.java
            ===================================================================
            --- PanelCollapsibleRenderer.java (revision 20162)
            +++ PanelCollapsibleRenderer.java (working copy)
            @@ -76,7 +76,7 @@
                                   panelCollapsible.isExpanded()+"'; " +
                                           "iceSubmit(document.forms['"+ form.getClientId(facesContext) +"'],this,event); return false;");
                         Element div = domContext.createElement(HTML.DIV_ELEM);
            - div.setAttribute(HTML.STYLE_ATTR, "padding:1px;background-image:none;width:100%;");
            + div.setAttribute(HTML.STYLE_ATTR, "padding:0px;background-image:none;width:100%;");
                         header.appendChild(div);
                         //this anchor should be known by the component only, so we are defining style to the component level
                         Element anchor = domContext.createElement(HTML.ANCHOR_ELEM);
            Show
            Patch Index: PanelCollapsibleRenderer.java =================================================================== --- PanelCollapsibleRenderer.java (revision 20162) +++ PanelCollapsibleRenderer.java (working copy) @@ -76,7 +76,7 @@                        panelCollapsible.isExpanded()+"'; " +                                "iceSubmit(document.forms['"+ form.getClientId(facesContext) +"'],this,event); return false;");              Element div = domContext.createElement(HTML.DIV_ELEM); - div.setAttribute(HTML.STYLE_ATTR, "padding:1px;background-image:none;width:100%;"); + div.setAttribute(HTML.STYLE_ATTR, "padding:0px;background-image:none;width:100%;");              header.appendChild(div);              //this anchor should be known by the component only, so we are defining style to the component level              Element anchor = domContext.createElement(HTML.ANCHOR_ELEM);

            Description

            Fix for ICE-4674 was not backward compatibile.
            Complex pageswith collapisble panel shows unexpected bottom scrollbar in IE browsers .

            The problem is in line 79 of PanelCollapsibleRenderer.java (updated with revision 19313 ) with content
                        div.setAttribute(HTML.STYLE_ATTR, "padding:1px;background-image:none;width:100%;");

            'padding 0px' resolve scrollbars problem.

              Issue Links

              depends on

              Improvement - An improvement or enhancement to an existing feature or task. ICE-4674 Add focus support to the panelCollapsible component

              • Major - Major loss of function.
              • Closed

                Activity

                Hide
                Permalink
                yip.ng added a comment -

                Suggested change applied.

                Revision: 20896

                Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelcollapsible/PanelCollapsibleRenderer.java

                Revision: 20897

                Modified : /icefaces-ee/branches/icefaces-ee-1.8.2/icefaces/component/src/com/icesoft/faces/component/panelcollapsible/PanelCollapsibleRenderer.java

                Show
                yip.ng added a comment - Suggested change applied. Revision: 20896 Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelcollapsible/PanelCollapsibleRenderer.java Revision: 20897 Modified : /icefaces-ee/branches/icefaces-ee-1.8.2/icefaces/component/src/com/icesoft/faces/component/panelcollapsible/PanelCollapsibleRenderer.java

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    Krashan Brahmanjara
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: