ICEfaces
  1. ICEfaces
  2. ICE-5274

compat: showcase D&D demo is throwing javascript error under IE

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-Alpha1
    • Fix Version/s: 2.0-Alpha2, 2.0.0
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      D&D

      Description

      compat: showcase D&D demo is throwing javascript error under IE

        Issue Links

          Activity

          Hide
          Adnan Durrani added a comment -

          As Mircea mentions that ice-extras.js contians the prototype.js as well as Scriptaculous js.

          I did the following tasks to test D&D:
          1- I removed the prototype code from the ice-extras.js. Tested the D&D, and it worked but it requires the demo link to be clicked twice. As describe by Mircea above.

          2- I applied the http://dev.rubyonrails.org/ticket/9416 patch to the prototype code in our ice-extras.js. Tested the D&D, and it worked but it requires the demo link to be clicked twice. As describe by Mircea above.

          Show
          Adnan Durrani added a comment - As Mircea mentions that ice-extras.js contians the prototype.js as well as Scriptaculous js. I did the following tasks to test D&D: 1- I removed the prototype code from the ice-extras.js. Tested the D&D, and it worked but it requires the demo link to be clicked twice. As describe by Mircea above. 2- I applied the http://dev.rubyonrails.org/ticket/9416 patch to the prototype code in our ice-extras.js. Tested the D&D, and it worked but it requires the demo link to be clicked twice. As describe by Mircea above.
          Hide
          Adnan Durrani added a comment -

          I looked the trunk/ icefaces.jar and noticed that the ice-extras.js generated dynamically by the build file. The build file concatenates prototype.js, scriptaculous.js and all component.js files and generates ice-extras.js. The prototype or scriptaculous library was never added separately to the icefaces jars. Which means no duplication.

          Show
          Adnan Durrani added a comment - I looked the trunk/ icefaces.jar and noticed that the ice-extras.js generated dynamically by the build file. The build file concatenates prototype.js, scriptaculous.js and all component.js files and generates ice-extras.js. The prototype or scriptaculous library was never added separately to the icefaces jars. Which means no duplication.
          Hide
          Adnan Durrani added a comment -

          I noticed that in the trunk first half of the prototype.js file goes inside the icefaces-d2d.js and rest of the half goes inside the ice-extras.js. However the compat is using one of the generated ice-extras.js from trunk which keeps second half of the protoypes.js only and missing first half. May be that is why we are force to add prototype.js separately.

          Show
          Adnan Durrani added a comment - I noticed that in the trunk first half of the prototype.js file goes inside the icefaces-d2d.js and rest of the half goes inside the ice-extras.js. However the compat is using one of the generated ice-extras.js from trunk which keeps second half of the protoypes.js only and missing first half. May be that is why we are force to add prototype.js separately.
          Hide
          Adnan Durrani added a comment -

          List of actions completed:

          1- Created trunk like folder structure to compat and moved the following folders "prototype", "scriptaculous" and "extras" to it. Change the build to generate the "icefaces-compat.js". Ran the the showcase, got the same javascript error on drag and drop. I noticed event trunk prototype.js contains the same cumulativeOffset() as compat.

          2- Used above steps but instead of using trunk's prototype I used latest prototype API. Ran the showcase, got other kind of component specifc javascript errors.

          3- Used above steps and instead of using trunk's extras I used compat's extras code. Ran the showcase and everything works fine.
          This is what we ended up:

          • Newer version of prototype
            glimmer\compat\core\src\main\javascript\prototype\prototype.js
          • Scriptaculous from the trunk
            glimmer\compat\core\src\main\javascript\scriptaculous*.js
          • Existing extras from compat but containing components code only.
            glimmer\compat\core\src\main\javascript\extras\extras.js
          • Modified build file, that merges all above files and creates "icefaces-compat.js".
          Show
          Adnan Durrani added a comment - List of actions completed: 1- Created trunk like folder structure to compat and moved the following folders "prototype", "scriptaculous" and "extras" to it. Change the build to generate the "icefaces-compat.js". Ran the the showcase, got the same javascript error on drag and drop. I noticed event trunk prototype.js contains the same cumulativeOffset() as compat. 2- Used above steps but instead of using trunk's prototype I used latest prototype API. Ran the showcase, got other kind of component specifc javascript errors. 3- Used above steps and instead of using trunk's extras I used compat's extras code. Ran the showcase and everything works fine. This is what we ended up: Newer version of prototype glimmer\compat\core\src\main\javascript\prototype\prototype.js Scriptaculous from the trunk glimmer\compat\core\src\main\javascript\scriptaculous*.js Existing extras from compat but containing components code only. glimmer\compat\core\src\main\javascript\extras\extras.js Modified build file, that merges all above files and creates "icefaces-compat.js".
          Hide
          Adnan Durrani added a comment -

          Modified: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\build.javascript.xml
          Modified: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\java\com\icesoft\faces\application\ExtrasSetup.java
          Modified: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\java\com\icesoft\faces\context\effects\JavascriptContext.java
          Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\extras
          Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\extras\extras.js
          Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\prototype
          Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\prototype\prototype.js
          Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous
          Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\builder.js
          Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\controls.js
          Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\dragdrop.js
          Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\effects.js
          Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\scriptaculous.js
          Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\slider.js
          Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\sound.js
          Deleting: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\resources\META-INF\resources\ice-extras.js
          Deleting: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\resources\META-INF\resources\prototype.js
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\controls.js
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\java\com\icesoft\faces\application\ExtrasSetup.java
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\builder.js
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\build.javascript.xml
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\sound.js
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\java\com\icesoft\faces\context\effects\JavascriptContext.java
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\prototype\prototype.js
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\extras\extras.js
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\effects.js
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\scriptaculous.js
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\dragdrop.js
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\slider.js
          Completed: At revision: 20270

          Show
          Adnan Durrani added a comment - Modified: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\build.javascript.xml Modified: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\java\com\icesoft\faces\application\ExtrasSetup.java Modified: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\java\com\icesoft\faces\context\effects\JavascriptContext.java Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\extras Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\extras\extras.js Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\prototype Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\prototype\prototype.js Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\builder.js Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\controls.js Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\dragdrop.js Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\effects.js Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\scriptaculous.js Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\slider.js Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\sound.js Deleting: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\resources\META-INF\resources\ice-extras.js Deleting: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\resources\META-INF\resources\prototype.js Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\controls.js Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\java\com\icesoft\faces\application\ExtrasSetup.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\builder.js Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\build.javascript.xml Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\sound.js Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\java\com\icesoft\faces\context\effects\JavascriptContext.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\prototype\prototype.js Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\extras\extras.js Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\effects.js Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\scriptaculous.js Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\dragdrop.js Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\glimmer\compat\core\src\main\javascript\scriptaculous\slider.js Completed: At revision: 20270

            People

            • Assignee:
              Adnan Durrani
              Reporter:
              Adnan Durrani
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: