ICEfaces
  1. ICEfaces
  2. ICE-5252

dataPaginator 'firstRowIndexVar' and 'lastRowIndexVer' are set incorrectly when dyanmically changing the rows value for the dataTable

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.8.2-EE-GA
          • Fix Version/s: 1.8.2-EE-GA_P01, 1.8.3
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            All
          • Assignee Priority:
            P2

            Description

            A drop down menu has been implemented to change the visible rows in the dataTable. If the backing table model has 20 entries and the rows is set to 5 by default the 'firstRowIndexVar' and the 'lastRowIndexVar' is displayed as "...from 1 to 5.". If for example the page is changed to page three it shows "...from 11 to 15.". Now if the rows value is changed to show 10 rows, the 'firstRowIndexVar' and the 'lastRowIndexVar' values now show "...from 1 to 10." even though it is on page two and therefore should show "...from 11 to 20.". Moving to the first page and then back sets the value to its proper values.

              Activity

              Ascending order - Click to sort in descending order
              Arran Mccullough created issue -
              Arran Mccullough made changes -
              Field Original Value New Value
              Salesforce Case [5007000000AoZri]
              Component/s Components [ 10012 ]
              Component/s Bridge [ 10011 ]
              Arran Mccullough made changes -
              Attachment ICE-5252.JPG [ 12141 ]
              Attachment Case8838Example.war [ 12142 ]
              Ken Fyten made changes -
              Assignee Adnan Durrani [ adnan.durrani ]
              Hide
              Permalink
              Ken Fyten added a comment -

              See if you can reproduce and figure out if there is something the component should do to reset the page number, or calc the correct row number to display at the top of the current page when the rowcount is changed dynamically.

              Show
              Ken Fyten added a comment - See if you can reproduce and figure out if there is something the component should do to reset the page number, or calc the correct row number to display at the top of the current page when the rowcount is changed dynamically.
              Ken Fyten made changes -
              Assignee Priority P3
              Ken Fyten made changes -
              Fix Version/s 1.8.2-EE-GA_P01 [ 10220 ]
              Fix Version/s 1.8.3 [ 10211 ]
              Assignee Priority P3 P2
              Hide
              Permalink
              Adnan Durrani added a comment -

              It seems like the valuechange of selectOneMenu is being called in INVOKE_APPLICATION. Is there any reason?

              Show
              Adnan Durrani added a comment - It seems like the valuechange of selectOneMenu is being called in INVOKE_APPLICATION. Is there any reason?
              Hide
              Permalink
              Arran Mccullough added a comment -

              So that it can update the UI/table, if it is left to run it its regular phase the UI is not updated unless the page is refreshed or another action occurs.

              Show
              Arran Mccullough added a comment - So that it can update the UI/table, if it is left to run it its regular phase the UI is not updated unless the page is refreshed or another action occurs.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #20460 Tue Feb 02 14:20:59 MST 2010 adnan.durrani Fix for ICE-5252 (dataPaginator 'firstRowIndexVar' and 'lastRowIndexVer' are set incorrectly when dyanmically changing the rows value for the dataTable.)
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/datapaginator/DataPaginator.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/HtmlDataTable.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #20462 Tue Feb 02 14:55:20 MST 2010 adnan.durrani Fix for ICE-5252 (dataPaginator 'firstRowIndexVar' and 'lastRowIndexVer' are set incorrectly when dyanmically changing the rows value for the dataTable.)
              firstRowIndexVar, lastRowIndexVar and displayedRowsCountVar has been fixed for displaying all records.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/datapaginator/DataPaginatorRenderer.java
              Adnan Durrani made changes -
              Status Open [ 1 ] In Progress [ 3 ]
              Hide
              Permalink
              Adnan Durrani added a comment -

              Fixed.

              Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java
              Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlDataTable.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlDataTable.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java
              Completed: At revision: 20460

              Show
              Adnan Durrani added a comment - Fixed. Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlDataTable.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlDataTable.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java Completed: At revision: 20460
              Adnan Durrani made changes -
              Status In Progress [ 3 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Adnan Durrani added a comment -

              Arran can you please verify it?

              Show
              Adnan Durrani added a comment - Arran can you please verify it?
              Hide
              Permalink
              Adnan Durrani added a comment -

              Modified: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java
              Modified: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\ext\HtmlDataTable.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\ext\HtmlDataTable.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java
              Completed: At revision: 20461

              Show
              Adnan Durrani added a comment - Modified: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java Modified: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\ext\HtmlDataTable.java Sending content: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\ext\HtmlDataTable.java Sending content: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java Completed: At revision: 20461
              Hide
              Permalink
              Adnan Durrani added a comment -

              firstRowIndexVar, lastRowIndexVar and displayedRowsCountVar has been fixed when displaying all records.

              Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginatorRenderer.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginatorRenderer.java
              Completed: At revision: 20462

              Modified: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginatorRenderer.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginatorRenderer.java
              Completed: At revision: 20463

              Show
              Adnan Durrani added a comment - firstRowIndexVar, lastRowIndexVar and displayedRowsCountVar has been fixed when displaying all records. Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginatorRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginatorRenderer.java Completed: At revision: 20462 Modified: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginatorRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginatorRenderer.java Completed: At revision: 20463
              Hide
              Permalink
              Arran Mccullough added a comment -

              Tested the fixes with my test case and they have resolved the issue, thanks!

              Show
              Arran Mccullough added a comment - Tested the fixes with my test case and they have resolved the issue, thanks!
              Joanne Bai made changes -
              Assignee Adnan Durrani [ adnan.durrani ] Joanne Bai [ joanne_bai ]
              Hide
              Permalink
              Joanne Bai added a comment -

              QA verified it with success too (using tomcat 6 + FF3.5 and IE8)

              Test app will be checked into repo\qa\trunk\Regression\ICE-5252

              Show
              Joanne Bai added a comment - QA verified it with success too (using tomcat 6 + FF3.5 and IE8) Test app will be checked into repo\qa\trunk\Regression\ ICE-5252
              Joanne Bai made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Joanne Bai
                  Reporter:
                  Arran Mccullough
                • Votes:
                  2 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: