[ICE-5252] dataPaginator 'firstRowIndexVar' and 'lastRowIndexVer' are set incorrectly when dyanmically changing the rows value for the dataTable - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 1.8.2-EE-GA
Fix Version/s: 1.8.2-EE-GA_P01, 1.8.3
Component/s: ICE-Components
Labels:
None
Environment:
All

Assignee Priority:
P2

Description

A drop down menu has been implemented to change the visible rows in the dataTable. If the backing table model has 20 entries and the rows is set to 5 by default the 'firstRowIndexVar' and the 'lastRowIndexVar' is displayed as "...from 1 to 5.". If for example the page is changed to page three it shows "...from 11 to 15.". Now if the rows value is changed to show 10 rows, the 'firstRowIndexVar' and the 'lastRowIndexVar' values now show "...from 1 to 10." even though it is on page two and therefore should show "...from 11 to 20.". Moving to the first page and then back sets the value to its proper values.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

Hide
Case8838Example.war

11/Jan/10 4:02 PM

6.27 MB

Arran Mccullough
META-INF/MANIFEST.MF 0.1 kB

META-INF/context.xml 0.1 kB

WEB-INF/classes/.../SortableList.class 1 kB

WEB-INF/classes/.../TableBean$1.class 2 kB

WEB-INF/.../TableBean$InventoryItem.class 1 kB

WEB-INF/classes/.../example/TableBean.class 5 kB

WEB-INF/faces-config.xml 0.5 kB

WEB-INF/lib/FastInfoset.jar 285 kB

WEB-INF/lib/backport-util-concurrent.jar 319 kB

WEB-INF/lib/commons-beanutils.jar 226 kB

WEB-INF/lib/commons-collections.jar 558 kB

WEB-INF/lib/commons-digester.jar 140 kB

WEB-INF/lib/commons-discovery.jar 75 kB

WEB-INF/lib/commons-el.jar 110 kB

WEB-INF/lib/commons-fileupload.jar 56 kB

WEB-INF/lib/commons-lang.jar 240 kB

WEB-INF/lib/commons-logging.jar 52 kB

WEB-INF/lib/icefaces-comps.jar 1.94 MB

WEB-INF/lib/icefaces.jar 1.18 MB

WEB-INF/lib/jsf-api.jar 356 kB

WEB-INF/lib/jsf-impl.jar 778 kB

WEB-INF/web.xml 3 kB

index.jsp 0.1 kB

main.jspx 10 kB

Download Zip
Show

Case8838Example.war

11/Jan/10 4:02 PM

6.27 MB

Arran Mccullough

ICE-5252.JPG

60 kB

11/Jan/10 4:02 PM

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Ken Fyten added a comment - 13/Jan/10 10:43 AM

See if you can reproduce and figure out if there is something the component should do to reset the page number, or calc the correct row number to display at the top of the current page when the rowcount is changed dynamically.

Show

Ken Fyten added a comment - 13/Jan/10 10:43 AM See if you can reproduce and figure out if there is something the component should do to reset the page number, or calc the correct row number to display at the top of the current page when the rowcount is changed dynamically.

Hide

Permalink

Adnan Durrani added a comment - 02/Feb/10 10:51 AM

It seems like the valuechange of selectOneMenu is being called in INVOKE_APPLICATION. Is there any reason?

Show

Adnan Durrani added a comment - 02/Feb/10 10:51 AM It seems like the valuechange of selectOneMenu is being called in INVOKE_APPLICATION. Is there any reason?

Hide

Permalink

Arran Mccullough added a comment - 02/Feb/10 10:55 AM

So that it can update the UI/table, if it is left to run it its regular phase the UI is not updated unless the page is refreshed or another action occurs.

Show

Arran Mccullough added a comment - 02/Feb/10 10:55 AM So that it can update the UI/table, if it is left to run it its regular phase the UI is not updated unless the page is refreshed or another action occurs.

Hide

Permalink

Adnan Durrani added a comment - 02/Feb/10 3:35 PM

Fixed.

Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlDataTable.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlDataTable.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java
Completed: At revision: 20460

Show

Adnan Durrani added a comment - 02/Feb/10 3:35 PM Fixed. Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlDataTable.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlDataTable.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java Completed: At revision: 20460

Hide

Permalink

Adnan Durrani added a comment - 02/Feb/10 3:35 PM

Arran can you please verify it?

Show

Adnan Durrani added a comment - 02/Feb/10 3:35 PM Arran can you please verify it?

Hide

Permalink

Adnan Durrani added a comment - 02/Feb/10 3:50 PM

Modified: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java
Modified: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\ext\HtmlDataTable.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\ext\HtmlDataTable.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java
Completed: At revision: 20461

Show

Adnan Durrani added a comment - 02/Feb/10 3:50 PM Modified: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java Modified: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\ext\HtmlDataTable.java Sending content: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\ext\HtmlDataTable.java Sending content: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java Completed: At revision: 20461

Hide

Permalink

Adnan Durrani added a comment - 02/Feb/10 4:11 PM

firstRowIndexVar, lastRowIndexVar and displayedRowsCountVar has been fixed when displaying all records.

Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginatorRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginatorRenderer.java
Completed: At revision: 20462

Show

Adnan Durrani added a comment - 02/Feb/10 4:11 PM firstRowIndexVar, lastRowIndexVar and displayedRowsCountVar has been fixed when displaying all records. Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginatorRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginatorRenderer.java Completed: At revision: 20462 Modified: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginatorRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginatorRenderer.java Completed: At revision: 20463

Hide

Permalink

Arran Mccullough added a comment - 02/Feb/10 4:47 PM

Tested the fixes with my test case and they have resolved the issue, thanks!

Show

Arran Mccullough added a comment - 02/Feb/10 4:47 PM Tested the fixes with my test case and they have resolved the issue, thanks!

Hide

Permalink

Joanne Bai added a comment - 19/Feb/10 2:20 PM

QA verified it with success too (using tomcat 6 + FF3.5 and IE8)

Test app will be checked into repo\qa\trunk\Regression\~~ICE-5252~~

Show

Joanne Bai added a comment - 19/Feb/10 2:20 PM QA verified it with success too (using tomcat 6 + FF3.5 and IE8) Test app will be checked into repo\qa\trunk\Regression\ ICE-5252

People

Assignee:

Joanne Bai

Reporter:

Arran Mccullough

Votes:

2 Vote for this issue

Watchers:

1 Start watching this issue

Dates

Created:

11/Jan/10 3:58 PM

Updated:

11/Mar/10 11:51 AM

Resolved:

02/Feb/10 3:35 PM